Logger sort of fixed #22
Conversation
llmv_routes.py
Outdated
| @@ -39,6 +41,12 @@ def llm_verification_index(): | |||
| @authed_only | |||
| def generate_for_challenge(): | |||
| """Add a route to CTFd for generating text from a prompt.""" | |||
| log.error("Log name %s, %s", log.name, log.level) | |||
| log.info("Received test generation request but his logger is not working for some reason") | |||
| log.error("NEW Received test generation request. Testing error level logging too") | |||
There was a problem hiding this comment.
For some reason info level logs don't print to console which is the main issue
There was a problem hiding this comment.
Something funny is going on where the llmv_routes logging is going to the wrong logger
There was a problem hiding this comment.
Maybe this. I'll figure it out tomorrow
https://stackoverflow.com/questions/27335686/adding-blueprints-to-flask-seems-to-break-logging
| @@ -11,13 +11,12 @@ | |||
| from .llmv_models import LlmSubmissionChallenge, fill_models_table | |||
| from .llmv_routes import add_routes | |||
|
|
|||
| log = getLogger(__name__) | |||
| log = initialize_llmvctfd_loggers(__name__) | |||
There was a problem hiding this comment.
This fixes an issue where other modules were not logging to console
| # Load the Vanilla Neox API key from the config file. | ||
|
|
||
| raw_response = post(url=route, | ||
| headers={'Authorization': f'Bearer {token}'}, | ||
| json={'prompt': prompt, "preprompt" : preprompt, "model": model}) | ||
|
|
||
| try: |
There was a problem hiding this comment.
Provides a much better exception message than the json decode I was getting before with the bad llmv_router
|
Ready for review. PR doesn't smoothly fix logging issue, just changes everything to error so it logs to console. It does add an extra exception handler which which provides readable exception of what is going wrong where I propose merging and then fixing logging handler issues in a separate PR. |
|
The logger seemed to work fine on my machine 😁. I think the solution to this is a new function in I'm not a fan of logging to error, but the rest looks good |
Tried this but it seems to make things worse. Leaving this branch open for now, moved the json exception handling to another PR since thats the bigger problem anyway = |
llmv_routes is not using the configured logger, detailed in the issue below. Still trying to figure it out
#21