Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#38 Added basic insertion in the file, improved tests. #43

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

aivinog1
Copy link
Owner

@aivinog1 aivinog1 commented Aug 9, 2019

This is a fix for #38. I've added a basic implementation of inserting some code (a line comment)

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #43 into master will increase coverage by 1.75%.
The diff coverage is 70%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #43      +/-   ##
============================================
+ Coverage     66.66%   68.42%   +1.75%     
  Complexity        4        4              
============================================
  Files             2        2              
  Lines            12       19       +7     
  Branches          1        3       +2     
============================================
+ Hits              8       13       +5     
  Misses            3        3              
- Partials          1        3       +2
Impacted Files Coverage Δ Complexity Δ
...aivinog1/pdd/plugin/template/CreateNewPddAction.kt 80% <70%> (-7.5%) 3 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a178cfc...3ab9320. Read the comment docs.

@aivinog1
Copy link
Owner Author

aivinog1 commented Aug 9, 2019

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Aug 9, 2019

@rultor merge

@aivinog1 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 3ab9320 into master Aug 9, 2019
@rultor
Copy link
Collaborator

rultor commented Aug 9, 2019

@rultor merge

@aivinog1 Done! FYI, the full log is here (took me 7min)

@aivinog1 aivinog1 deleted the first-impl-create-action branch August 9, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants