Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve container versions and OpenAPI spec links through host-meta.json (RFC-6415) #3

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@schrieveslaach
Copy link
Contributor

schrieveslaach commented Apr 9, 2019

When requesting the list of apps, PREvant tries to resolve .well-known/host-meta.json for each service which should provide versioning information and the link to the OpenAPI specification.

Resolve container versions and OpenAPI spec links through host-meta.j…
…son (RFC-6415)

When requesting the list of apps, PREvant tries to resolve .well-known/host-meta.json
for each service which should provide versioning information and the link to the OpenAPI
specification.

@schrieveslaach schrieveslaach requested a review from x1B Apr 9, 2019

@x1B

x1B approved these changes Apr 9, 2019

Copy link

x1B left a comment

Not sure I understand all the details, but LGTM.
I added two comments where something came to mind, but nothing that needs to be addressed within this PR.

Show resolved Hide resolved api/src/models/service.rs
)
.header(
"X-Forwarded-Prefix",
format!("/{}/{}", app_name, service_name),

This comment has been minimized.

Copy link
@x1B

x1B Apr 9, 2019

One might add recursive Proxy support here (prepending any incoming X-Forwarded-Prefix).
Maybe this is premature, but somehow I get the feeling it'll be useful sooner or later.

This comment has been minimized.

Copy link
@schrieveslaach

schrieveslaach Apr 16, 2019

Author Contributor

Do you think of scenarios in which PREvant is running behind another proxy?

This comment has been minimized.

Copy link
@schrieveslaach

schrieveslaach Apr 16, 2019

Author Contributor

If so, do you want to add an issue so that we can keep track of it?

This comment has been minimized.

Copy link
@x1B

x1B Apr 19, 2019

Good call, I opened #4 for this

@schrieveslaach schrieveslaach merged commit a85eed3 into master Apr 16, 2019

@schrieveslaach schrieveslaach deleted the feature/host-meta.json branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.