Resolve container versions and OpenAPI spec links through host-meta.json (RFC-6415) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…son (RFC-6415) When requesting the list of apps, PREvant tries to resolve .well-known/host-meta.json for each service which should provide versioning information and the link to the OpenAPI specification.
x1B
approved these changes
Apr 9, 2019
| ) | ||
| .header( | ||
| "X-Forwarded-Prefix", | ||
| format!("/{}/{}", app_name, service_name), |
There was a problem hiding this comment.
One might add recursive Proxy support here (prepending any incoming X-Forwarded-Prefix).
Maybe this is premature, but somehow I get the feeling it'll be useful sooner or later.
There was a problem hiding this comment.
Do you think of scenarios in which PREvant is running behind another proxy?
There was a problem hiding this comment.
If so, do you want to add an issue so that we can keep track of it?
There was a problem hiding this comment.
Good call, I opened #4 for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting the list of apps, PREvant tries to resolve .well-known/host-meta.json for each service which should provide versioning information and the link to the OpenAPI specification.