Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed global phantomjs requirement #3

Merged
merged 1 commit into from
Aug 7, 2015

Conversation

abenrob
Copy link

@abenrob abenrob commented Aug 7, 2015

If we add the phantomjs module, we can use node-phantom's 'phantomPath' option. This allows us to avoid the requirement for a global install of an old phantomjs version (and a global install of anything, for that matter.) Helps devs who need different versions of phantomjs, and helps deploy by not having to install phantom on server.

@abenrob abenrob mentioned this pull request Aug 7, 2015
mhkeller added a commit that referenced this pull request Aug 7, 2015
removed global phantomjs requirement
@mhkeller mhkeller merged commit 738a42e into ajam:master Aug 7, 2015
@mhkeller
Copy link

mhkeller commented Aug 7, 2015

That's great, thanks!

@mhkeller
Copy link

mhkeller commented Aug 7, 2015

Forgot to uninstall phantomjs before, testing. Getting the following error. Does the config object need to be passed to create()>

  ph.createPage(openPage);
      ^
TypeError: Cannot read property 'createPage' of undefined
    at createPage (/Users/michael.keller/wrk/code/banquo/src/banquo.js:43:7)
    at /Users/michael.keller/wrk/code/banquo/node_modules/node-phantom/node-phantom.js:65:6
    at null._onTimeout (/Users/michael.keller/wrk/code/banquo/node_modules/node-phantom/node-phantom.js:43:5)

@mhkeller
Copy link

mhkeller commented Aug 7, 2015

Nevermind. It was still picking up the old path. Reinstalling node modules fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants