[FIX] end tag with space after name should be valid #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ie <a></a > is a valid xml
marinsokol5
reviewed
Nov 2, 2023
| var regex = new RegExp("\\s*>"); | ||
| var subSource = source.substr(i+2); | ||
| var end = subSource.search(regex); | ||
| end = end + i + 2; |
There was a problem hiding this comment.
Hmm, that doesn't seem the same.
So in case when I forget to close the tag:
<Select>
</Select
end would be -1 because indexOf wouldn't find it
but in the new code end would be -1 + i + 2, so something else entirely.
Can we change this to something like: end = endIndex === -1 ? endIndex: endIndex + i + 2
I am pretty sure it breaks something otherwise, because, this is the current error:
And this is the new one:
marinsokol5
reviewed
Nov 2, 2023
| var lastIndex = source.lastIndexOf(match[match.length-1]); | ||
| pos = closeMap[tagName] = lastIndex; | ||
| } else { | ||
| pos = -1; |
There was a problem hiding this comment.
Can we also keep the same chain assignment from above here, so pos = closeMap[tagName] = -1 just to keep the previous logic the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xml End tag may have spaces after name.
is a valid xml.