Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identifierRegexps variable in Completer interface #4378

Merged

Conversation

Sunwoo-Shin
Copy link
Contributor

Related issues #1670

Description of changes:

added to make it possible to change the identifierRegexps variable in the Completer interface of the type script module.

Example

import {Ace} from "ace-builds";

const completers: RegexpsCompleter = {
      identifierRegexps: [/[a-zA-Z_0-9\\$\-\u00A2-\u2000\u2070-\uFFFF.]/],
      getCompletions (editor: Ace.Editor, session: Ace.EditSession, pos: Ace.Point, prefix: string, callback: Ace.CompleterCallback): void {
            ...
      }
}

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Sunwoo-Shin
Copy link
Contributor Author

I don't understand why the test error occurred in the following logic. (The modified file is .ts format.)
Could you please explain the reason for the error?

changes=$(git diff --name-only origin/HEAD --no-renames --diff-filter=ACMR);
if [ "$changes" == "" ]; then
      echo "checking all files";
      node node_modules/eslint/bin/eslint "lib/ace/**/*.js";
else
      changes=$(echo "$changes" | grep -P '.js$');
      echo "checking $changes";
       if [ "$changes" != "" ]; then
             node node_modules/eslint/bin/eslint $changes;
       fi
fi

@nightwing nightwing merged commit 55fc737 into ajaxorg:master Oct 29, 2020
@nightwing
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants