Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wrong next state in regex state in Lucene and SQLServer modes #5139

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Apr 25, 2023

Issue #, if available: #5135

Description of changes:

  • Fix wrong next state in Lucene mode
  • Fix wrong next state in SQLServer mode
  • Add test to check all modes for possible wrong next states

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (990745a) 86.83% compared to head (aac99ad) 86.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5139   +/-   ##
=======================================
  Coverage   86.83%   86.83%           
=======================================
  Files         558      558           
  Lines       43718    43731   +13     
  Branches     6794     6795    +1     
=======================================
+ Hits        37962    37975   +13     
  Misses       5756     5756           
Flag Coverage Δ
unittests 86.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mode/lucene_highlight_rules.js 100.00% <ø> (ø)
src/mode/sqlserver_highlight_rules.js 100.00% <ø> (ø)
src/mode/_test/highlight_rules_test.js 65.53% <100.00%> (+1.78%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nightwing
Copy link
Member

In _test folder we have some tests for similar situations, could you add one for this too

@mkslanc mkslanc changed the title Fix: wrong next state in regex state in Lucene mode Fix: wrong next state in regex state in Lucene and SQLServer modes Apr 26, 2023
@nightwing nightwing merged commit 8fe099b into ajaxorg:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants