Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publishing generated styling files to ace-code package #5152

Merged
merged 1 commit into from
May 3, 2023

Conversation

marinsokol5
Copy link
Contributor

@marinsokol5 marinsokol5 commented May 3, 2023

Description of changes:

import ace from "ace-code";
import 'ace-code/styles/ace.css';
import 'ace-code/styles/theme/dawn.css';
ace.config.set('useStrictCSP', true);

Testing

  • Ran npm publish --dry-run and verified that the style files are now published. New size of the package is 5.9MB versus previous 4.4MB.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@marinsokol5 marinsokol5 requested a review from nightwing May 3, 2023 09:35
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3c4a81d) 86.84% compared to head (1fa223e) 86.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5152   +/-   ##
=======================================
  Coverage   86.84%   86.84%           
=======================================
  Files         558      558           
  Lines       43734    43734           
  Branches     6793     6793           
=======================================
  Hits        37980    37980           
  Misses       5754     5754           
Flag Coverage Δ
unittests 86.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marinsokol5 marinsokol5 merged commit 41700d0 into master May 3, 2023
@marinsokol5 marinsokol5 deleted the publish-styles-to-ace-code branch May 3, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants