Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set role annotation and add inline unfold to nls #5176

Merged
merged 1 commit into from
May 19, 2023

Conversation

akoreman
Copy link
Contributor

Two small fixes:

  • Adds 'button' role to gutter annotations.
  • Adds title of inline unfold button to the externalized translations.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d455e9b) 86.98% compared to head (31a6d64) 86.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5176   +/-   ##
=======================================
  Coverage   86.98%   86.98%           
=======================================
  Files         565      565           
  Lines       45103    45107    +4     
  Branches     6931     6931           
=======================================
+ Hits        39231    39235    +4     
  Misses       5872     5872           
Flag Coverage Δ
unittests 86.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/layer/gutter.js 90.69% <100.00%> (+0.08%) ⬆️
src/layer/text.js 91.78% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@InspiredGuy InspiredGuy merged commit cc95e42 into ajaxorg:master May 19, 2023
3 checks passed
@akoreman akoreman deleted the annotation_role branch May 27, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants