Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mode-mysql] Fix autocomplete typo: “groupby_concat” → “group_concat” #5195

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

shaunlebron
Copy link
Contributor

Description

This PR corrects a typo in the autocompletion keyword groupby_concat for MySQL mode.

It should be group_concat instead:

CleanShot 2023-06-06 at 14 31 24@2x

Affected users

Some metabase users have noted this autocompletion typo:

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6bebb4e) 87.13% compared to head (46c428c) 87.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5195   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files         564      564           
  Lines       45021    45021           
  Branches     6909     6909           
=======================================
  Hits        39229    39229           
  Misses       5792     5792           
Flag Coverage Δ
unittests 87.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mode/mysql_highlight_rules.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@akoreman
Copy link
Contributor

akoreman commented Jun 7, 2023

Thanks for your contribution.

@akoreman akoreman merged commit c90eaa1 into ajaxorg:master Jun 7, 2023
@shaunlebron
Copy link
Contributor Author

Thank you! Will v1.22.1 be rolled soon?

@akoreman
Copy link
Contributor

akoreman commented Jun 7, 2023

We don't have a set release schedule for Ace but I'll do a release this week.

@shaunlebron shaunlebron deleted the patch-1 branch June 8, 2023 15:50
@akoreman
Copy link
Contributor

Ace 1.22.1 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants