Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(autocomplete): fix a11y violations #5241

Merged
merged 3 commits into from
Jul 7, 2023
Merged

bug(autocomplete): fix a11y violations #5241

merged 3 commits into from
Jul 7, 2023

Conversation

oykuyilmaz
Copy link
Contributor

@oykuyilmaz oykuyilmaz commented Jul 6, 2023

Accessibility violations for autocompletion popover are fixed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (67d318e) 87.24% compared to head (fcab9d7) 87.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5241   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files         565      565           
  Lines       45283    45284    +1     
  Branches     6928     6928           
=======================================
+ Hits        39505    39506    +1     
  Misses       5778     5778           
Flag Coverage Δ
unittests 87.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/autocomplete/popup.js 85.38% <100.00%> (+0.05%) ⬆️
src/autocomplete_test.js 97.68% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@akoreman akoreman merged commit decb615 into master Jul 7, 2023
3 checks passed
@akoreman akoreman deleted the a11y branch July 7, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants