Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for safari rendering bug #5573

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

nightwing
Copy link
Member

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.77%. Comparing base (a3277ea) to head (4bc49b6).

Files Patch % Lines
src/virtual_renderer.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5573      +/-   ##
==========================================
- Coverage   86.78%   86.77%   -0.01%     
==========================================
  Files         594      594              
  Lines       43017    43020       +3     
  Branches     7129     7130       +1     
==========================================
+ Hits        37331    37332       +1     
- Misses       5686     5688       +2     
Flag Coverage Δ
unittests 86.77% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marinsokol5
Copy link
Contributor

Reproduction steps:

Screenshot 2024-06-03 at 10 59 14

@nightwing
Copy link
Member Author

could you try https://raw.githack.com/nightwing/ace/4bc49b6734f94cfd4dd64ad63d84dad2cf87baae/kitchen-sink.html which resets scroller background instead?

@InspiredGuy
Copy link
Contributor

could you try https://raw.githack.com/nightwing/ace/4bc49b6734f94cfd4dd64ad63d84dad2cf87baae/kitchen-sink.html which resets scroller background instead?

@nightwing it works now in Safari

Copy link
Contributor

@InspiredGuy InspiredGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as a workaround until Safari bug is fixed

@InspiredGuy InspiredGuy merged commit f9a152f into ajaxorg:master Jun 11, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants