Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move right of cursor tokens to end of ghost text. #5616

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

akoreman
Copy link
Contributor

@akoreman akoreman commented Jul 22, 2024

Issue #, if available: NA

Description of changes: When inserting ghost text in the middle of a line, move the tokens to the right of the cursor to the end of the ghost text to have the ghost text state be the same as it will look after insertion into the doc.

Screen.Recording.2024-07-22.at.09.52.17.mov

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (26eda25) to head (03d5152).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5616      +/-   ##
==========================================
+ Coverage   86.89%   86.91%   +0.02%     
==========================================
  Files         594      594              
  Lines       43151    43222      +71     
  Branches     7151     7155       +4     
==========================================
+ Hits        37497    37568      +71     
  Misses       5654     5654              
Flag Coverage Δ
unittests 86.91% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman marked this pull request as ready for review July 22, 2024 11:39
@akoreman akoreman changed the title [wip] fix: move right of cursor tokens to end of ghost text. fix: move right of cursor tokens to end of ghost text. Jul 22, 2024
Copy link
Contributor

@andredcoliveira andredcoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@akoreman akoreman merged commit 063ef9b into ajaxorg:master Jul 22, 2024
3 checks passed
@akoreman akoreman deleted the ghost_text_hiding branch July 22, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants