Skip to content
This repository has been archived by the owner on Nov 21, 2020. It is now read-only.

Change Instasearch View Key Bind #98

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

zaerald
Copy link
Contributor

@zaerald zaerald commented Oct 26, 2018

On Issue #85 there seems to have a problem with the key binding because the key binding has an M4 binding which only Mac OSX has binding on the CTRL.
This PR changed the key binding to support other platforms

From the eclipse documentation:

M1 is the COMMAND key on MacOSX and the CTRL key on most other platforms
...
M4 is the CTRL key on MacOS X, and is undefined on other platforms

but changing only the M4 to M1 creates a conflict between the other key binding, so I added a new modifier M2.

After this PR is merged all platforms can now open the Instasearch view with the following key binding:

  • Mac: ⌘ + ⌥ + ⇧ + I
  • Other Platforms: ⌃ + Alt + ⇧ + I

@ajermakovics ajermakovics merged commit 4f8523d into ajermakovics:master Oct 26, 2018
@zaerald zaerald deleted the topic-Change-key-bind branch October 27, 2018 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants