Make "listen-on-v6" a configurable option #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the "listen-on-v6" option was hard-coded to the value "any" which limited IPv6 configurability. This commit adds dns::server::options::listen_on_ipv6, allowing an array of values to be provided for the config option.
|
Hi. Here's the output of a successful |
| it { should contain_file('/etc/bind/named.conf.options').with_content(/2001:db8:2::\/124;$/) } | ||
| end | ||
|
|
||
| context 'when passing a string to listen_on_ipv6' do |
There was a problem hiding this comment.
I don't think you realy have to double check the validate_array function, it will be fine
solarkennedy
added a commit
that referenced
this pull request
Aug 5, 2015
Make "listen-on-v6" a configurable option
|
Thanks! |
|
Glad I could contribute. Thanks for a great module 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the "listen-on-v6" option was hard-coded to the value "any" which limited IPv6 configurability.
This commit adds dns::server::options::listen_on_ipv6, allowing an array of values to be provided for the config option.