Create ns.pp #53
Create ns.pp #53
Conversation
It allows to insert NS records into db zone files
|
It is just an adaptation, I didn't find anyway to add NS records using the modules already written, so I did this.. |
| host => $host, | ||
| ttl => $ttl, | ||
| record => 'NS', | ||
| preference => $preference, |
There was a problem hiding this comment.
Why set a preference? This doesn't seem to make sense for a NS record?
There was a problem hiding this comment.
Actually I don't need a preference, just a way to automatically insert NS records, and this one worked... I can just erase that line, It's ok...
There was a problem hiding this comment.
Yes please, copied+pasted things that are unnecessary are confusing.
Also I fixed the rspec upgrade breakage, if you post a new diff the tests should pass.
We don't currently test these dns::record wrappers, so I guess I wan't make you write tests for this particular functionality? (would be nice to have)
There was a problem hiding this comment.
Already done. I hope it will be util for more people!
Removed unused variable
Inserted NS record option. This option allows to create a NS record into zones.
| host => $host, | ||
| ttl => $ttl, | ||
| record => 'NS', | ||
| data => "${data}.", |
There was a problem hiding this comment.
Do you have justification for the ending "." ? I see it in MX, but I don't know if I agree with it.
What if you don't want it to end in a "." ?
Seems like it should be left up to the user if they are going to fully qualify and use a "." or not.
There was a problem hiding this comment.
Well, I didn't think the user could want to have this option, (I never needed to use without ".") but it's simple leave without, I will just add a sample to be used with and without "."
Thanks for notice that!!
Removed "." in $data, so the user can chose by his own put "." or not
Updated option for NS entries
| dns::record::ns { | ||
| 'example.com.': | ||
| zone => 'example.com', | ||
| # data => ["dns1.example.com.", "dns2.example.com"]; # Two NS for the domain |
There was a problem hiding this comment.
I don't like the commented out thing. Just have two examples if you want to show the array and put the comments at the top of the code block.
But if you do do that, be consistent, because you are missing the dot on the second one, which might surprise someone.
Also, use single quotes in your strings for that to follow the puppet style guide. It is a nice to have, and makes your example code look like official code.
Code reorganized in NS records
| # Note: Multiple NS can be used as following sample: data => ['dns1.example.com.', 'dns2.example.com.']; | ||
| dns::record::ns { | ||
| 'example.com.': | ||
| zone => 'example.com', |
There was a problem hiding this comment.
I know I'm being a stickler here, but the example source code on the readme should be consistent with other code on the readme as well as the official puppet style guide. Make it look like this
dns::record::ns { 'example.com.':
zone => 'example.com',
data => "$hostname.example.com.";
}
typo correction
Module Install updated
Example Using Hiera to feed the script
It allows to insert NS records into db zone files