Refactor: BitTypeValue.Instance, private constructor

ajlopez · Jul 17, 2011 · 129923a · 129923a
1 parent 45a5a3e
commit 129923a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/AjVars.Tests/TypeValueTests.cs b/AjVars.Tests/TypeValueTests.cs
@@ -118,7 +118,7 @@ public void ShortToAndFromMemory()
         [TestMethod]
         public void ParseBitTypeValueFromBooleanString()
         {
-            TypeValue type = new BitTypeValue();
+            TypeValue type = BitTypeValue.Instance;
 
             Assert.AreEqual(false, type.ParseString("false"));
             Assert.AreEqual(true, type.ParseString("true"));
@@ -133,7 +133,7 @@ public void ParseBitTypeValueFromBooleanString()
         [TestMethod]
         public void ParseBitTypeValueFromZeroOneString()
         {
-            TypeValue type = new BitTypeValue();
+            TypeValue type = BitTypeValue.Instance;
 
             Assert.AreEqual(false, type.ParseString("0"));
             Assert.AreEqual(true, type.ParseString("1"));
@@ -143,7 +143,7 @@ public void ParseBitTypeValueFromZeroOneString()
         public void SetAndGetBitTypeValueUsingMemory()
         {
             ByteMemory memory = new ByteMemory();
-            TypeValue type = new BitTypeValue();
+            TypeValue type = BitTypeValue.Instance;
 
             type.ToMemory(memory, 10, true);
             Assert.IsTrue(memory.GetBit(10));

diff --git a/AjVars/BitTypeValue.cs b/AjVars/BitTypeValue.cs
@@ -7,6 +7,14 @@
 
     public class BitTypeValue : TypeValue
     {
+        private static BitTypeValue instance = new BitTypeValue();
+
+        private BitTypeValue()
+        {
+        }
+
+        public static BitTypeValue Instance { get { return instance; } }
+
         public override object FromMemory(ByteMemory memory, int address)
         {
             return memory.GetBit(address);

diff --git a/AjVars/BitVariable.cs b/AjVars/BitVariable.cs
@@ -9,7 +9,7 @@
     public class BitVariable : Variable
     {
         public BitVariable(int address, ByteMemory memory)
-            : base(address, new BitTypeValue(), memory)
+            : base(address, BitTypeValue.Instance, memory)
         {
         }
     }