Skip to content
This repository has been archived by the owner on Oct 5, 2018. It is now read-only.

Commit

Permalink
Merge pull request #254 from ajoberstar/rel-1.7.1
Browse files Browse the repository at this point in the history
Fix username-only credentials
  • Loading branch information
ajoberstar committed Apr 9, 2017
2 parents fe8d229 + 0488e16 commit b65855c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ dependencies {
compile gradleApi()

// grgit
compile 'org.ajoberstar:grgit:1.9.0'
compile 'org.ajoberstar:grgit:1.9.1'

// semver
compile 'com.github.zafarkhaja:java-semver:0.9.0'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,14 @@ class RebuildVersionStrategy implements VersionStrategy {
@Override
boolean selector(Project project, Grgit grgit) {
def clean = grgit.status().clean
def props = project.properties.keySet().find { it.startsWith('release.') }
def propsSpecified = project.hasProperty(SemVerStrategy.SCOPE_PROP) || project.hasProperty(SemVerStrategy.STAGE_PROP)
def headVersion = getHeadVersion(project, grgit)

if (clean && props == null && headVersion) {
if (clean && !propsSpecified && headVersion) {
logger.info('Using {} strategy because repo is clean, no "release." properties found and head version is {}', name, headVersion)
return true
} else {
logger.info('Skipping {} strategy because clean is {}, "release." properties are {} and head version is {}', name, clean, props, headVersion)
logger.info('Skipping {} strategy because clean is {}, "release." properties are {} and head version is {}', name, clean, propsSpecified, headVersion)
return false
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class RebuildVersionStrategySpec extends Specification {
def 'selector returns false if any release properties are set'() {
given:
mockClean(true)
Project project = getProject('release.anything': 'value')
Project project = getProject('release.scope': 'value')
mockTagsAtHead('v1.0.0')
expect:
!strategy.selector(project, grgit)
Expand Down

0 comments on commit b65855c

Please sign in to comment.