Update RemoteAddOp.groovy #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment - If remote with given name already exists, its URIs are replaced with newly specified ones. Is incorrect, doesn't actually replace with new ones.
fixed find syntax
|
In this case I think the issue is that the Javadoc is incorrect, not that the behavior should have matched the Javadoc. On the CLI, remote add fails if the remote already exists. I think it makes more keep that same behavior here. I'll update the comment in the javadoc, and will be closing this PR. |
ajoberstar
added a commit
that referenced
this pull request
Apr 22, 2016
Comment currently is incorrect about the behavior of the class. #108 proposed changing the behavior to match the comment, but the CLI `git remote add <origin> <url>` will fail if the remote already exists. This class should follow that same behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment - If remote with given name already exists, its URIs are replaced with newly specified ones.
Is incorrect, doesn't actually replace with new ones.