This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
Fix/tab no modifiers #709
Merged
Fix/tab no modifiers #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperstorm
approved these changes
Aug 1, 2021
tarkah
force-pushed
the
fix/tab-no-modifiers
branch
from
d73d8cf
to
797f28c
Compare
|
It's still not fixed even in 1.3.0 Windows 10 LTSB 1809 |
It appears the issue is when alt-tabbing back to Ajour. When alt-tabbing away from Ajour, the tab doesn't change. It seems the issue is when you alt-tab back to Ajour, and release the Tab key once Ajour is back in focus. This is the behavior on Windows, but the problem doesn't occur on Linux. The bigger issue is we are capturing these hotkeys on key released, instead of key pressed. I believe switching over to key pressed should resolve this issue. @casperstorm any issues with making this change? |
|
Hmm, changing to on key pressed actually makes this problem now occur on Linux as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Proposed Changes
Checklist
CHANGELOG.mdif knowledge of this change could be valuable to users