Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add npm scripts #9

Merged
merged 2 commits into from
Jan 12, 2018
Merged

Chore: add npm scripts #9

merged 2 commits into from
Jan 12, 2018

Conversation

JPeer264
Copy link
Contributor

@JPeer264 JPeer264 commented Jan 8, 2018

Actually you have done everything right in #5 (comment). I just assume you have called the scripts wrongly. Once you have set up your npm scripts, you also have to call them as such. In this PR I introduced the scripts watch and build. These should be executed as npm run watch or npm run build (as I mentioned in the Dev Setup).

Just a hint, if you want to test that gulp is running in your npm scripts, you can write ./node_modules/.bin/gulp into your shell. As in ./node_modules/.bin are all modules which are executable within your npm script (hope this was not confusing).

Here I added a screenshot to illustrate it. In the first section I ran gulp, but gulp is not installed globally - so the command is unknown. In the second part, I ran gulp via the local node_modules. And in the third part, I run everything in the npm scripts, where nothing is installed globally now. But this does not mean you can't have a globally version of gulp as well 馃憤

screen shot 2018-01-08 at 18 19 10

Btw, within your Dev Docs I changed the path in (now) point 5. I just added a ./ before, so it is obvious that it is a directory in the root.

@ajusa
Copy link
Owner

ajusa commented Jan 9, 2018

I'll take a look at this tomorrow

@JPeer264 JPeer264 changed the title Chore/scripts Chore: add npm scripts Jan 9, 2018
@ajusa ajusa merged commit 6bcad83 into ajusa:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants