Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually you have done everything right in #5 (comment). I just assume you have called the scripts wrongly. Once you have set up your npm scripts, you also have to call them as such. In this PR I introduced the scripts
watch
andbuild
. These should be executed asnpm run watch
ornpm run build
(as I mentioned in the Dev Setup).Just a hint, if you want to test that
gulp
is running in your npm scripts, you can write./node_modules/.bin/gulp
into your shell. As in./node_modules/.bin
are all modules which are executable within your npm script (hope this was not confusing).Here I added a screenshot to illustrate it. In the first section I ran
gulp
, butgulp
is not installed globally - so the command is unknown. In the second part, I rangulp
via the localnode_modules
. And in the third part, I run everything in the npm scripts, where nothing is installed globally now. But this does not mean you can't have a globally version ofgulp
as well 馃憤Btw, within your Dev Docs I changed the path in (now) point 5. I just added a
./
before, so it is obvious that it is a directory in the root.