Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the Node v4 #51

Closed
akabekobeko opened this issue Mar 18, 2017 · 2 comments
Closed

Drop the Node v4 #51

akabekobeko opened this issue Mar 18, 2017 · 2 comments
Milestone
v1.1.0

Comments

@akabekobeko
Copy link
Owner

akabekobeko commented Mar 18, 2017 •
edited

Supports Node v4. use strict is necessary to use let, ...etc.

Drop the Node v4.

  • Dependent npm svg2png does not support Node v4
  • In Node LTS v4 was changed from Active to Maintenance to 2017-04-01
@akabekobeko akabekobeko added this to the v1.0.8 milestone Mar 18, 2017
akabekobeko added a commit that referenced this issue Mar 18, 2017
@akabekobeko
#51 Support the Node v4
4749caa
akabekobeko added a commit that referenced this issue Mar 18, 2017
@akabekobeko
#51 Node v4 does not support spread operator, so it is fixed so that …
cb29694 
…it is not used
@akabekobeko
Copy link
Owner Author

svg2png does not seem to work on node v4.

/home/travis/build/akabekobeko/npm-icon-gen/node_modules/svg2png/lib/svg2png.js:28

function getPhantomJSArgs(options = {}) {

@akabekobeko
Copy link
Owner Author

svg2png uses the latest in ES2015 features, and as such requires a recent version of Node.js. Only the 6.x series onward is supported.

@akabekobeko akabekobeko changed the title Support the Node v4 Drop the Node v4 Apr 5, 2017
akabekobeko added a commit that referenced this issue Apr 6, 2017
@akabekobeko
#51 Drop the Node v4
ce4bb0b
akabekobeko added a commit that referenced this issue Apr 6, 2017
@akabekobeko
#51 Update the version of Node
a71dfd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@akabekobeko