Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command to open caniuse.com for feature. #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nchutchind
Copy link

Used the same as the default behavior, but with a different shortcut will open the browser to caniuse.com/selectedWord.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 00eaea8 on nchutchind:master into 8fb16ad on akamud:master.

@akamud
Copy link
Owner

akamud commented Jul 16, 2016

Hi, thank you for sending this, I looked at the code and I see that you are using the selected word to send to CanIUse, they use keywords for most of the rules, so just sending the selected word won't work for many rules.

To address this I started using a "mapping" file so it always send the correct keyword to CanIUse. You can see it in use in here.

You should change your code to use this mapping file before calling caniuse.com

@yangg
Copy link

yangg commented Oct 11, 2016

I think click the status bar to open caniuse.com is also a good feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants