Higher Precision Response Time Results

[numeralnathan]

Please increase the precision of all response time results. Several tests have response times near 1 ms. When trying out a patch, it is difficult to know how much the patch was changed.

Currently, average and maximum response times are reported to the nearest 1 ms. 90th and 99th percentile response times are reported to the nearest 10 ms. The request is to report average and maximum response times to the nearest 1 us. 90th and 99th percentile response times to the nearest 1 ms.

I realize that this will consume more memory. Please make this a configuration option so that it can be turned on for more precision and turned off for saving memory.

Here's a list of changes to com.sun.faban.driver.engine.Metrics.java needed to enable 1 us and 1 ms precision.

• Change RESPBUCKET_SIZE_RATIO = 100
• In the constructor, change the following line to that shown here: fineRespBucketSize = maxPctNanos / 2000l; // Added 1 more zero
• In printSummary(), change the format from 5.3 to 8.6.
  formatter.format("%8.6f\n", result.avgResp[i]);
  formatter.format("%8.6f\n", result.maxResp[i]);
  formatter.format("%8.6f\n", result.respSD[i]);

Note: The printSummary() changes could be made without increasing the amount of memory required. It will simply increase the number of digits printed in the result.

[shanti]

You don't need such changes at all.
You can specify the unit for your response times in the 'responseTimeUnit'
parameter of the BenchmarkDriver annotation in your driver class.
Set it to MICROSECONDS or even NANOSECONDS.

Shanti

On Tue, Jul 9, 2013 at 3:34 PM, nathanila notifications@github.com wrote:

Please increase the precision of all response time results. Several tests
have response times near 1 ms. When trying out a patch, it is difficult to
know how much the patch was changed.

Currently, average and maximum response times are reported to the nearest
1 ms. 90th and 99th percentile response times are reported to the nearest
10 ms. The request is to report average and maximum response times to the
nearest 1 us. 90th and 99th percentile response times to the nearest 1 ms.

I realize that this will consume more memory. Please make this a
configuration option so that it can be turned on for more precision and
turned off for saving memory.

Here's a list of changes to com.sun.faban.driver.engine.Metrics.java
needed to enable 1 us and 1 ms precision.

• Change RESPBUCKET_SIZE_RATIO = 100
• In the constructor, change the following line to that shown here:
  fineRespBucketSize = maxPctNanos / 2000l; // Added 1 more zero
• In printSummary(), change the format from 5.3 to 8.6.
  formatter.format("%8.6f\n", result.avgResp[i]); formatter.format("%8.6f\n",
  result.maxResp[i]); formatter.format("%8.6f\n", result.respSD[i]);

Note: The printSummary() changes could be made without increasing the
amount of memory required. It will simply increase the number of digits
printed in the result.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/54
.