Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Congigure fails when MSL_SHARED=ON and SPIRV_TOOLS_BUILD_STATIC=OFF #6

Closed
yurivict opened this issue Jun 20, 2022 · 1 comment
Closed

Congigure fails when MSL_SHARED=ON and SPIRV_TOOLS_BUILD_STATIC=OFF #6

yurivict opened this issue Jun 20, 2022 · 1 comment

Comments

@yurivict
Copy link 

CMake Error: install(EXPORT "MSLCompileTargets" ...) includes target "msl_compile" which requires target "SPIRV-Tools-opt" that is not in any export set.
CMake Error in Compile/CMakeLists.txt:
  export called with target "msl_compile" which requires target
  "SPIRV-Tools-opt" that is not in any export set.

Version: 1.5.1
@akb825 akb825 closed this as completed in 5845611 Jun 20, 2022
@akb825
Copy link
Owner

akb825 commented Jun 20, 2022

I fixed this with the latest revision. In case you were setting SPIRV_TOOLS_BUILD_STATIC=OFF manually to ensure the full package is installed with shared libraries, the SPIRV-Tools libraries I use are statically linked with libmsl_compile.so and not exposed externally to the library. The static SPIRV-Tools libraries also aren't a part of the install package.

akb825 added a commit that referenced this issue Jun 20, 2022
@akb825
Various CMake fixes and improvements.
f8a4701 
* Set MSL_SHARED to ON by default if BUILD_SHARED_LIBS is set to ON.
  (fixes #4)
* Updated SPIRV-Tools fork to ignore SPIRV_TOOLS_BUILD_STATIC as static
  libraries are always expected. (fixes #6)
* Make detection of flatbuffers more robust. Flatbuffers will now only be
  generated if both flatc and the headers are found. CMake generation will
  also force the flatbuffers to be rebuilt to avoid cases like a fresh
  checkout not considering the file dirty. (fixes #5)

Updated the Windows build image to the latest and build against the v141
(or Visual Studio 2017) runtime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yurivict @akb825