Skip to content

Commit

Permalink
TIP-843: Fix comment review
Browse files Browse the repository at this point in the history
  • Loading branch information
@arnolanglade
arnolanglade committed Aug 13, 2018
1 parent 580f7f4 commit 8c075a2
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 7 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG-1.4.md
View file
Expand Up @@ -496,7 +496,7 @@
- Remove arguments ChannelRepositoryInterface, LocaleRepositoryInterface, add argument AttributeValuesResolver in Pim/Bundle/CatalogBundle/Builder/ProductBuilder constructor
- Remove arguments DenormalizerInterface, ValidatorInterface, ObjectDetacherInterface, $class from the constructor of Pim/Bundle/BaseConnectorBundle/Processor/Denormalization/AbstractProcessor
- Add methods `getReferenceDataName` and `setReferenceDataName` to Pim\Bundle\CatalogBundle\Model\AttributeInterface.
- Change constructor of `Pim\Bundle\EnrichBundle\Controller\MassEditActionController`, removed `Pim\Bundle\EnrichBundle\MassEditAction\OperatorRegistry`, `Pim\Bundle\DataGridBundle\Extension\MassAction\MassActionDispatcher`, `$massEditLimit`, added `Pim\Bundle\DataGridBundle\Adapter\GridFilterAdapterInterface`, `Akeneo\Tool\Bundle\ConnectorBundle\JobLauncher\SimpleJobLauncher`, `Akeneo\Bundle\BatchBundle\Job\DoctrineJobRepository`, `Akeneo\Bundle\BatchBundle\Connector\ConnectorRegistry`, `Pim\Bundle\EnrichBundle\MassEditAction\Operation\OperationRegistryInterface`, `Pim\Bundle\EnrichBundle\MassEditAction\MassEditFormResolver`
- Change constructor of `Pim\Bundle\EnrichBundle\Controller\MassEditActionController`, removed `Pim\Bundle\EnrichBundle\MassEditAction\OperatorRegistry`, `Pim\Bundle\DataGridBundle\Extension\MassAction\MassActionDispatcher`, `$massEditLimit`, added `Pim\Bundle\DataGridBundle\Adapter\GridFilterAdapterInterface`, `Pim\Bundle\ConnectorBundle\JobLauncher\SimpleJobLauncher`, `Akeneo\Bundle\BatchBundle\Job\DoctrineJobRepository`, `Akeneo\Bundle\BatchBundle\Connector\ConnectorRegistry`, `Pim\Bundle\EnrichBundle\MassEditAction\Operation\OperationRegistryInterface`, `Pim\Bundle\EnrichBundle\MassEditAction\MassEditFormResolver`
- Remove `Pim\Bundle\EnrichBundle\Form\Subscriber\MassEditAction\AddSelectedOperationSubscriber`
- Change constructor of `Pim\Bundle\EnrichBundle\Form\Type\MassEditAction\AddToGroupsType`, added `Pim\Bundle\CatalogBundle\Repository\GroupRepositoryInterface` as first argument
- Change constructor of `Pim\Bundle\EnrichBundle\Form\Type\MassEditAction\AddToVariantGroupType`, added `Pim\Bundle\CatalogBundle\Repository\ProductMassActionRepositoryInterface` as first argument and `Pim\Bundle\CatalogBundle\Repository\GroupRepositoryInterface` as second argument
Expand Down
8 changes: 4 additions & 4 deletions CHANGELOG-1.6.md
View file
Expand Up @@ -329,9 +329,9 @@
- Change constructor of `Pim\Bundle\EnrichBundle\Normalizer\GroupNormalizer`. Add `Pim\Component\Catalog\Localization\Localizer\AttributeConverterInterface`
- Change constructor of `Pim\Bundle\EnrichBundle\Normalizer\ProductNormalizer`. Add `Pim\Component\Catalog\Localization\Localizer\AttributeConverterInterface`
- Change constructor of `Pim\Component\Connector\Processor\Normalization\VariantGroupProcessor`. Remove second argument `Symfony\Component\Serializer\Normalizer\DenormalizerInterface` and replace fourth and fifth argument by `Pim\Component\Connector\Processor\BulkMediaFetcher` and `Akeneo\Component\StorageUtils\Updater\ObjectUpdaterInterface`
- Move `Pim\Bundle\BaseConnectorBundle\DependencyInjection\Compiler\RegisterArchiversPass` to `Akeneo\Tool\Bundle\ConnectorBundle\DependencyInjection\Compiler\RegisterArchiversPass`
- Move `Pim\Bundle\BaseConnectorBundle\EventListener\InvalidItemsCollector` to `Akeneo\Tool\Bundle\ConnectorBundle\EventListener\InvalidItemsCollector`
- Move `Pim\Bundle\BaseConnectorBundle\EventListener\JobExecutionArchivist` to `Akeneo\Tool\Bundle\ConnectorBundle\EventListener\JobExecutionArchivist`
- Move `Pim\Bundle\BaseConnectorBundle\DependencyInjection\Compiler\RegisterArchiversPass` to `Pim\Bundle\ConnectorBundle\DependencyInjection\Compiler\RegisterArchiversPass`
- Move `Pim\Bundle\BaseConnectorBundle\EventListener\InvalidItemsCollector` to `Pim\Bundle\ConnectorBundle\EventListener\InvalidItemsCollector`
- Move `Pim\Bundle\BaseConnectorBundle\EventListener\JobExecutionArchivist` to `Pim\Bundle\ConnectorBundle\EventListener\JobExecutionArchivist`
- Move `Pim\Bundle\BaseConnectorBundle\Archiver\AbstractFilesystemArchiver` to `Pim\Component\Connector\Archiver\AbstractFilesystemArchiver`
- Move `Pim\Bundle\BaseConnectorBundle\Archiver\ArchivableFileWriterArchiver` to `Pim\Component\Connector\Archiver\ArchivableFileWriterArchiver`
- Move `Pim\Bundle\BaseConnectorBundle\Archiver\ArchiverInterface` to `Pim\Component\Connector\Archiver\ArchiverInterface`
Expand Down Expand Up @@ -498,7 +498,7 @@
- Remove `TransformBundle`
- Change constructor of `Pim\Component\Catalog\Updater\GroupUpdater` and `Pim\Component\Catalog\Updater\VariantGroupUpdater`, add `Pim\Component\Catalog\Repository\AttributeRepositoryInterface`
- Change constructor of `Akeneo\Bundle\BatchBundle\Job\Pim\Bundle\TransformBundle\Normalizer\Structured\FamilyNormalizer` to inject two more dependendies `Pim\Component\Catalog\Repository\AttributeRepositoryInterface` and `Pim\Component\Catalog\Repository\AttributeRequirementRepositoryInterface`
- Remove class `Akeneo\Tool\Bundle\ConnectorBundle\JobLauncher\SimpleJobLauncher` which overrides `Akeneo\Bundle\BatchBundle\Launcher\SimpleJobLauncher` we now always use `@akeneo_batch.launcher.simple_job_launcher` and not anymore `@pim_connector.launcher.simple_job_launcher`
- Remove class `Pim\Bundle\ConnectorBundle\JobLauncher\SimpleJobLauncher` which overrides `Akeneo\Bundle\BatchBundle\Launcher\SimpleJobLauncher` we now always use `@akeneo_batch.launcher.simple_job_launcher` and not anymore `@pim_connector.launcher.simple_job_launcher`
- Remove parameter `Pim\Component\Connector\Repository\JobConfigurationRepositoryInterface` from constructors of
`Pim\Bundle\EnrichBundle\Connector\Processor\AbstractProcessor`
`Pim\Bundle\EnrichBundle\Connector\Processor\MassEdit\Family\SetAttributeRequirements`
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG-2.0.md
View file
Expand Up @@ -1245,7 +1245,7 @@ IMPORTANT: In order for your PIM to work properly, you will need to run the foll
- Change the constructor of `Pim\Bundle\EnrichBundle\Connector\Processor\QuickExport\ProductProcessor` to replace `Pim\Component\Catalog\Builder\ProductBuilder` by `Pim\Component\Catalog\ValuesFiller\EntityWithFamilyValuesFillerInterface`
- Change the constructor of `Pim\Bundle\EnrichBundle\Controller\ProductController` to add `Pim\Component\Catalog\ValuesFiller\EntityWithFamilyValuesFillerInterface`
- Change the constructor of `Akeneo\Bundle\BatchBundle\Launcher\SimpleJobLauncher` to add `Akeneo\Component\Batch\Job\JobParametersValidator`
- Change the constructor of `Akeneo\Tool\Bundle\ConnectorBundle\Launcher\AuthenticatedJobLauncher` to add `Akeneo\Component\Batch\Job\JobParametersValidator`
- Change the constructor of `Pim\Bundle\ConnectorBundle\Launcher\AuthenticatedJobLauncher` to add `Akeneo\Component\Batch\Job\JobParametersValidator`
- Change the constructor of `Pim\Bundle\AnalyticsBundle\DataCollector\VersionDataCollector` to replace `string` by `Pim\Bundle\InstallerBundle\InstallStatusManager\InstallStatusManager` - Change the constructor of `Pim\Bundle\EnrichBundle\Controller\Rest\JobInstanceController` to add `uploadTmpDir` (string)
- Change the constructor of `Pim\Component\Connector\Processor\Denormalization\ProductProcessor` to add `Pim\Component\Catalog\Builder\ProductBuilderInterface` as the 3rd argument (variant product builder).
- Change the constructor of `Pim\Bundle\EnrichBundle\Controller\Rest\JobInstanceController` to add `uploadTmpDir` (string)
Expand Down
13 changes: 12 additions & 1 deletion CHANGELOG-3.0.md
View file
Expand Up @@ -480,7 +480,6 @@
- Move `Pim\Component\Connector\Job\ComputeDataRelatedToFamilyProductsTasklet` to `Akeneo\Pim\Enrichment\Component\Product\Connector\Job\ComputeDataRelatedToFamilyProductsTasklet`
- Move `Pim\Component\Connector\Job\ComputeDataRelatedToFamilyRootProductModelsTasklet` to `Akeneo\Pim\Enrichment\Component\Product\Connector\Job\ComputeDataRelatedToFamilyRootProductModelsTasklet`
- Move `Pim\Component\Connector\Job\ComputeDataRelatedToFamilySubProductModelsTasklet` to `Akeneo\Pim\Enrichment\Component\Product\Connector\Job\ComputeDataRelatedToFamilySubProductModelsTasklet`
- Move `Pim\Component\Connector` to `Akeneo\Tool\Component\Connector`
- Move `Pim\Component\Connector\Analyzer\AnalyzerInterface` to `Akeneo\Tool\Component\Connector\Analyzer\AnalyzerInterface`
- Move `Pim\Component\Connector\Archiver\AbstractFilesystemArchiver` to `Akeneo\Tool\Component\Connector\Archiver\AbstractFilesystemArchiver`
- Move `Pim\Component\Connector\Archiver\ArchivableFileWriterArchiver` to `Akeneo\Tool\Component\Connector\Archiver\ArchivableFileWriterArchiver`
Expand Down Expand Up @@ -543,3 +542,15 @@
- Move `Pim\Component\Connector\Writer\File\MediaExporterPathGenerator` to `Akeneo\Tool\Component\Connector\Writer\File\MediaExporterPathGenerator`
- Move `Pim\Component\Connector\Writer\File\Csv\Writer` to `Akeneo\Tool\Component\Connector\Writer\File\Csv\Writer`
- Move `Pim\Component\Connector\Writer\File\Yaml\Writer` to `Akeneo\Tool\Component\Connector\Writer\File\Yaml\Writer`
- Move `Pim\Bundle\ConnectorBundle\Command\AnalyzeProductCsvCommand` to `Akeneo\Tool\Bundle\ConnectorBundle\Command\AnalyzeProductCsvCommand`
- Move `Pim\Bundle\ConnectorBundle\DependencyInjection\Compiler\RegisterArchiversPass` to `Akeneo\Tool\Bundle\ConnectorBundle\DependencyInjection\Compiler\RegisterArchiversPass`
- Move `Pim\Bundle\ConnectorBundle\DependencyInjection\Compiler\RegisterStandardToFlatConverterPass` to `Akeneo\Tool\Bundle\ConnectorBundle\DependencyInjection\Compiler\RegisterStandardToFlatConverterPass`
- Move `Pim\Bundle\ConnectorBundle\DependencyInjection\Compiler\RegisterStandardToFlatConverterPass` to `Akeneo\Tool\Bundle\ConnectorBundle\DependencyInjection\Compiler\RegisterStandardToFlatConverterPass`
- Move `Pim\Bundle\ConnectorBundle\DependencyInjection\PimConnectorExtension` to `Akeneo\Tool\Bundle\ConnectorBundle\DependencyInjection\PimConnectorExtension`
- Move `Pim\Bundle\ConnectorBundle\Doctrine\UnitOfWorkAndRepositoriesClearer` to `Akeneo\Tool\Bundle\ConnectorBundle\Doctrine\UnitOfWorkAndRepositoriesClearer`
- Move `Pim\Bundle\ConnectorBundle\EventListener\ClearBatchCacheSubscriber` to `Akeneo\Tool\Bundle\ConnectorBundle\EventListener\ClearBatchCacheSubscriber`
- Move `Pim\Bundle\ConnectorBundle\EventListener\InvalidItemsCollector` to `Akeneo\Tool\Bundle\ConnectorBundle\EventListener\InvalidItemsCollector`
- Move `Pim\Bundle\ConnectorBundle\EventListener\JobExecutionAuthenticator` to `Akeneo\Tool\Bundle\ConnectorBundle\EventListener\JobExecutionAuthenticator`
- Move `Pim\Bundle\ConnectorBundle\EventListener\ResetProcessedItemsBatchSubscriber` to `Akeneo\Tool\Bundle\ConnectorBundle\EventListener\ResetProcessedItemsBatchSubscriber`
- Move `Pim\Bundle\ConnectorBundle\PimConnectorBundle` to `Akeneo\Tool\Bundle\ConnectorBundle\PimConnectorBundle`

11 changes: 11 additions & 0 deletions UPGRADE.md
View file
Expand Up @@ -445,6 +445,17 @@ find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Component\\Connector\\Writ
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Component\\Connector\\Validator\\Constraints/Akeneo\\Pim\\Enrichment\\Component\\Product\\Validator\\Constraints/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Component\\Connector\\ArrayConverter\\FlatToStandard\\User/Akeneo\\UserManagement\\Component\\Connector\\ArrayConverter\\FlatToStandard\\User/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Component\\Connector\\ArrayConverter\\StandardToFlat\\User/Akeneo\\UserManagement\\Component\\Connector\\ArrayConverter\\StandardToFlat\\User/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Bundle\\ConnectorBundle\\Command\\AnalyzeProductCsvCommand/Akeneo\\Tool\\Bundle\\ConnectorBundle\\Command\\AnalyzeProductCsvCommand/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Bundle\\ConnectorBundle\\DependencyInjection\\Compiler\\RegisterArchiversPass/Akeneo\\Tool\\Bundle\\ConnectorBundle\\DependencyInjection\\Compiler\\RegisterArchiversPass/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Bundle\\ConnectorBundle\\DependencyInjection\\Compiler\\RegisterStandardToFlatConverterPass/Akeneo\\Tool\\Bundle\\ConnectorBundle\\DependencyInjection\\Compiler\\RegisterStandardToFlatConverterPass/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Bundle\\ConnectorBundle\\DependencyInjection\\Compiler\\RegisterStandardToFlatConverterPass/Akeneo\\Tool\\Bundle\\ConnectorBundle\\DependencyInjection\\Compiler\\RegisterStandardToFlatConverterPass/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Bundle\\ConnectorBundle\\DependencyInjection\\PimConnectorExtension/Akeneo\\Tool\\Bundle\\ConnectorBundle\\DependencyInjection\\PimConnectorExtension/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Bundle\\ConnectorBundle\\Doctrine\\UnitOfWorkAndRepositoriesClearer/Akeneo\\Tool\\Bundle\\ConnectorBundle\\Doctrine\\UnitOfWorkAndRepositoriesClearer/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Bundle\\ConnectorBundle\\EventListener\\ClearBatchCacheSubscriber/Akeneo\\Tool\\Bundle\\ConnectorBundle\\EventListener\\ClearBatchCacheSubscriber/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Bundle\\ConnectorBundle\\EventListener\\InvalidItemsCollector/Akeneo\\Tool\\Bundle\\ConnectorBundle\\EventListener\\InvalidItemsCollector/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Bundle\\ConnectorBundle\\EventListener\\JobExecutionAuthenticator/Akeneo\\Tool\\Bundle\\ConnectorBundle\\EventListener\\JobExecutionAuthenticator/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Bundle\\ConnectorBundle\\EventListener\\ResetProcessedItemsBatchSubscriber/Akeneo\\Tool\\Bundle\\ConnectorBundle\\EventListener\\ResetProcessedItemsBatchSubscriber/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Bundle\\ConnectorBundle\\PimConnectorBundle/Akeneo\\Tool\\Bundle\\ConnectorBundle\\PimConnectorBundle/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Component\\Connector\\Analyzer\\AnalyzerInterface/Akeneo\\Tool\\Component\\Connector\\Analyzer\\AnalyzerInterface/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Component\\Connector\\Archiver\\AbstractFilesystemArchiver/Akeneo\\Tool\\Component\\Connector\\Archiver\\AbstractFilesystemArchiver/g'
find ./src/ -type f -print0 | xargs -0 sed -i 's/Pim\\Component\\Connector\\Archiver\\ArchivableFileWriterArchiver/Akeneo\\Tool\\Component\\Connector\\Archiver\\ArchivableFileWriterArchiver/g'
Expand Down

0 comments on commit 8c075a2

Please sign in to comment.