Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIM-9899: update add custom rule doc #1645

Merged
merged 1 commit into from Jun 16, 2021
Merged

PIM-9899: update add custom rule doc #1645

merged 1 commit into from Jun 16, 2021

Conversation

nmarniesse
Copy link
Contributor

@nmarniesse nmarniesse commented Jun 14, 2021 •
edited

Description

Update the documentation to add a custom rule:

  • add the getType() method to properly implement ActionInterface
  • remove twig template and translation that is now useless after the front refacto

Definition Of Done

Q A
Technical Review and 2 GTM Todo
English Review and 1 GTM Todo

Todo: Pending / Work in progress
OK: Done / Validated
-: Not needed

@nmarniesse nmarniesse merged commit f540c4f into master Jun 16, 2021
@nmarniesse nmarniesse deleted the PIM-9899 branch June 16, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierallard pierallard pierallard approved these changes

@mmetayer mmetayer mmetayer approved these changes

@pierrejolly pierrejolly pierrejolly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nmarniesse @pierallard @mmetayer @pierrejolly