Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix window resize on emacs27 #72

Closed
wants to merge 2 commits into from
Closed

Conversation

jixiuf
Copy link
Collaborator

@jixiuf jixiuf commented Mar 24, 2019

get this error on emacs 27

Error during redisplay: (vterm--window-size-change #<window 13 on ll ~>) signaled (error "Window is on a different frame")

and I see

window-size-change-functions is a variable defined in ‘C source code’.
Its value is nil

  This variable’s value is permanent if it is given a local binding.
  This variable may be risky if used as a file-local variable.

Documentation:
Functions called during redisplay when window sizes have changed.
The value should be a list of functions that take one argument.

Functions specified buffer-locally are called for each window showing
the corresponding buffer if and only if that window has been added or
changed its buffer or its total or body size since the last redisplay.
In this case the window is passed as argument.

Functions specified by the default value are called for each frame if
at least one window on that frame has been added or changed its buffer
or its total or body size since the last redisplay.  In this case the
frame is passed as argument.

@jhacksworth
Copy link

Thank you! This works great and fixes a popup window size issue for me when the frame is split into multiple windows.

@jixiuf jixiuf force-pushed the fix-window-resize branch 2 times, most recently from 8df8979 to d569dd8 Compare April 21, 2019 13:51
@akermu
Copy link
Owner

akermu commented Apr 28, 2019

Thanks! I fixed this in `6adcedf' with a little bit simpler implementation.

@akermu akermu closed this Apr 28, 2019
@jixiuf jixiuf deleted the fix-window-resize branch April 29, 2019 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants