Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to React 15.5 #31

Merged
merged 5 commits into from
May 4, 2017
Merged

Migrate to React 15.5 #31

merged 5 commits into from
May 4, 2017

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Apr 19, 2017

Closes #29 & closes #30

CC: @akiran

@MichaelDeBoey
Copy link
Contributor Author

@akiran I think this can be merged isn't it?

});
}

Highlight.defaultProps = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, why not making it a static variable to the Highlight class?
Like this:

class Highlight extends Component {
  static defaultProps = {
    // ...
  };
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommanded way to use the prop-types package is like I did it and like you can see in the docs :-)

@flyfloor
Copy link

@akiran when will you merge this PR?

@XaxisJosh
Copy link

Would love to see this merged in soon. it's causing some warnings in my app.

@lunochkin
Copy link

Merged this PR in forked version and updated it.
You can use this package instead:
https://www.npmjs.com/package/@maxlun86/react-highlight

@akiran akiran merged commit f90e0eb into akiran:master May 4, 2017
@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented May 4, 2017

Thanks for updating @akiran! 🙂

I think you can delete your scoped package @maksim-lunochkin (and maybe you can add a new PR with your changes) 🙂

@lunochkin
Copy link

Yeah, deleted it

@akiran
Copy link
Owner

akiran commented May 4, 2017

Thanks for the PR @MichaelDeBoey

@MichaelDeBoey
Copy link
Contributor Author

Your welcome @akiran 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants