-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to React 15.5 #31
Conversation
@akiran I think this can be merged isn't it? |
}); | ||
} | ||
|
||
Highlight.defaultProps = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious, why not making it a static variable to the Highlight class?
Like this:
class Highlight extends Component {
static defaultProps = {
// ...
};
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recommanded way to use the prop-types
package is like I did it and like you can see in the docs :-)
@akiran when will you merge this PR? |
Would love to see this merged in soon. it's causing some warnings in my app. |
Merged this PR in forked version and updated it. |
Thanks for updating @akiran! 🙂 I think you can delete your scoped package @maksim-lunochkin (and maybe you can add a new PR with your changes) 🙂 |
Yeah, deleted it |
Thanks for the PR @MichaelDeBoey |
Your welcome @akiran 🙂 |
Closes #29 & closes #30
CC: @akiran