Periodically Send Demo Traffic #46
Conversation
versilis
commented
Apr 11, 2023
versilis
commented
- Add demo server stubs
- Add demo-server to docker-compose.yaml
- Fix priority of stubs
- go mod tidy
- Update agent config model to contain a demo field
- Add provider for the demo server client
- Add methods to send demo server traffic
- Add repo method to send mock traffic
- Add interactor for sending of demo traffic
- Send demo traffic periodically in the background
# Conflicts: # demo-server/mappings/stubs.json # vm/go.mod
vm/infrastructure/repo/demo.go
Outdated
| err := d.demoServer.GetBreed() | ||
| if err != nil { | ||
| glog.Errorf("failed to send breed request: %v", err) | ||
| } | ||
|
|
||
| err = d.demoServer.PostTrick() | ||
| if err != nil { | ||
| glog.Errorf("failed to send trick request: %v", err) | ||
| } | ||
|
|
||
| err = d.demoServer.GetBreed() | ||
| if err != nil { | ||
| glog.Errorf("failed to send breed request: %v", err) | ||
| } |
There was a problem hiding this comment.
calling GetBreed twice and PostTrick once feels a bit arbitrary to me. Any reason not to send one of each, or uniform-randomly pick one of the supported requests to perform on each call?
There was a problem hiding this comment.
I was thinking that it would be nice to see the difference in request counts between the two endpoints.
I don't feel too strongly about this implementation, so I'll leave the conversation open if you think it's worth either picking an API randomly or just sending one of each.
There was a problem hiding this comment.
No objection, would only suggest that a comment might help dissuade future readers from wondering the same thing as I did! Another option would be to randomize the calls so that 33% are PostTrick and 67% are GetBreed :)
vm/infrastructure/repo/demo.go
Outdated
| err := d.demoServer.GetBreed() | ||
| if err != nil { | ||
| glog.Errorf("failed to send breed request: %v", err) | ||
| } | ||
|
|
||
| err = d.demoServer.PostTrick() | ||
| if err != nil { | ||
| glog.Errorf("failed to send trick request: %v", err) | ||
| } | ||
|
|
||
| err = d.demoServer.GetBreed() | ||
| if err != nil { | ||
| glog.Errorf("failed to send breed request: %v", err) | ||
| } |
There was a problem hiding this comment.
No objection, would only suggest that a comment might help dissuade future readers from wondering the same thing as I did! Another option would be to randomize the calls so that 33% are PostTrick and 67% are GetBreed :)
Update comments based on suggestions Fix bug
This adds a toggle-able demo to the Docker Extension UI. When "Demo Mode" is toggled, Akita will send stub requests to a mock server which will be used by the agent for traffic collection. https://user-images.githubusercontent.com/100976287/231302994-34d4fb0a-5e57-4974-8b64-5a37115ea7dc.mov Depends on: #46
