Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces a build and test GH workflow #1325

Merged
merged 13 commits into from
May 3, 2021

Conversation

ignasi35
Copy link
Member

@ignasi35 ignasi35 commented Apr 14, 2021

References #1324 (built on top of #1326 so the PR runs the new workflow)

This is part of the migrations:

  1. from Travis to GH Actions (Migrate from travis to gitHub Actions #1324)
    1. migrate compile and test
    2. migrate release jobs
  2. from Bintray to Sonatype (Migrate to Sonatype from bintray #1323)

This first PR is down-scoped to migrating the build and test jobs (1.1).

Once these compile and test jobs (1.1) in GH Actions are stable, I would migrate the release jobs from Travis/Bintray to GHActions/Sonatype in a single PR. That is, I would do 1.2. and 2. at once.

@ignasi35 ignasi35 mentioned this pull request Apr 14, 2021
@ignasi35 ignasi35 force-pushed the migrate-to-github-actions-build-and-test branch from e32e7e1 to aad7602 Compare April 14, 2021 11:49
@ignasi35 ignasi35 changed the base branch from master to basic-gh-action April 14, 2021 11:49
Base automatically changed from basic-gh-action to master April 14, 2021 12:45
@ignasi35 ignasi35 closed this Apr 14, 2021
@ignasi35 ignasi35 reopened this Apr 14, 2021
@ignasi35
Copy link
Member Author

ignasi35 commented Apr 14, 2021

In the build for commit 37efe93 there seems to be a consistent failure in tests for NonBalancingIntegrationSpecAkkaHttp:

[INFO] [04/14/2021 13:02:30.167] [pool-8-thread-4-ScalaTest-running-NonBalancingIntegrationSpecAkkaHttp] [akka.actor.ActorSystemImpl(NonBalancingIntegrationSpec)] Starting test: re-discover endpoints on failure
[INFO] [04/14/2021 13:02:30.178] [pool-8-thread-4-ScalaTest-running-NonBalancingIntegrationSpecAkkaHttp] [akka.actor.ActorSystemImpl(NonBalancingIntegrationSpec)] Sending requests to server 1
[INFO] [04/14/2021 13:02:35.201] [pool-8-thread-4-ScalaTest-running-NonBalancingIntegrationSpecAkkaHttp] [akka.actor.ActorSystemImpl(NonBalancingIntegrationSpec)] Sending requests to server 2
[info] NonBalancingIntegrationSpecAkkaHttp:
[info] Using pick-first (non load balanced clients)
[info] - should send requests to a single endpoint (424 milliseconds)
[info] - should send requests to a single endpoint that is restarted in the middle (335 milliseconds)
[info] - should re-discover endpoints on failure (5 seconds, 51 milliseconds)
[info] - should select the right endpoint among invalid ones *** FAILED *** (5 seconds, 25 milliseconds)
[info]   A timeout occurred waiting for a future to complete. Waited 5000000000 nanoseconds. (NonBalancingIntegrationSpec.scala:145)
[info]   org.scalatest.concurrent.ScalaFutures$$anon$1$$anon$2:
[info]   at org.scalatest.concurrent.ScalaFutures$$anon$1.futureValueImpl(ScalaFutures.scala:339)
[info]   at org.scalatest.concurrent.Futures$FutureConcept.futureValue(Futures.scala:476)
[info]   at org.scalatest.concurrent.Futures$FutureConcept.futureValue$(Futures.scala:475)
[info]   at org.scalatest.concurrent.ScalaFutures$$anon$1.futureValue(ScalaFutures.scala:281)
[info]   at akka.grpc.scaladsl.NonBalancingIntegrationSpec.$anonfun$new$11(NonBalancingIntegrationSpec.scala:145)
[info]   at akka.grpc.scaladsl.NonBalancingIntegrationSpec.$anonfun$new$11$adapted(NonBalancingIntegrationSpec.scala:144)
[info]   at scala.collection.immutable.Range.foreach(Range.scala:190)
[info]   at akka.grpc.scaladsl.NonBalancingIntegrationSpec.$anonfun$new$10(NonBalancingIntegrationSpec.scala:144)
[info]   at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info]   at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info]   at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:22)
[info]   at org.scalatest.Transformer.apply(Transformer.scala:20)

It has failed in all 4 build-test jobs (scalaVersion-jdkVersion matrix).


The following build (commit b9c2c25) passed 3 of the 4 build-test jobs.

I think NonBalancingIntegrationSpecAkkaHttp is a flaky test.

@ignasi35
Copy link
Member Author

PS: Using GH Actions is a lot faster than using Travis. By the time all jobs for commit b9c2c25 had completed in GHActions, neither of the travis builds had yet started.

@@ -39,7 +39,7 @@ class NonBalancingIntegrationSpec(backend: String)
implicit val mat = SystemMaterializer(system).materializer
implicit val ec = system.dispatcher

override implicit val patienceConfig: PatienceConfig = PatienceConfig(5.seconds, Span(10, org.scalatest.time.Millis))
override implicit val patienceConfig: PatienceConfig = PatienceConfig(15.seconds, Span(10, org.scalatest.time.Millis))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if that makes the tests a bit less flaky on GHActions

@ignasi35
Copy link
Member Author

I think the main blocker for this to move on is the flakiness of NonBalancingIntegrationSpecAkkaHttp.

@ignasi35 ignasi35 marked this pull request as draft April 19, 2021 13:10
@raboof raboof force-pushed the migrate-to-github-actions-build-and-test branch from 26c938c to 1d49881 Compare May 3, 2021 12:47
@raboof
Copy link
Member

raboof commented May 3, 2021

(took the liberty of rebasing on top of #1331 to see how that affects this PR)

@raboof
Copy link
Member

raboof commented May 3, 2021

Ironic that on this PR introducing GH Actions, the travis tests are red (specifically NonBalancingIntegrationSpec.scala:59 - perhaps 3 seconds is a bit tight still, will widen)

Comment on lines 137 to 141
// A first successful request. A vanilla probe...
val discoveryHappyPath = new MutableServiceDiscovery(List(server.localAddress))
val serviceClient =
GreeterServiceClient(GrpcClientSettings.usingServiceDiscovery("greeter", discoveryHappyPath).withTls(false))
serviceClient.sayHello(HelloRequest(s"Hello")).futureValue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not anymore, no.

@ignasi35 ignasi35 marked this pull request as ready for review May 3, 2021 16:16
@ignasi35 ignasi35 force-pushed the migrate-to-github-actions-build-and-test branch from 6ef141a to f3d0e4b Compare May 3, 2021 17:17
@raboof raboof merged commit c76f7ee into master May 3, 2021
@ignasi35 ignasi35 deleted the migrate-to-github-actions-build-and-test branch July 5, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants