-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduces a build and test GH workflow #1325
Conversation
e32e7e1
to
aad7602
Compare
In the build for commit 37efe93 there seems to be a consistent failure in tests for
It has failed in all 4 build-test jobs (scalaVersion-jdkVersion matrix). The following build (commit b9c2c25) passed 3 of the 4 build-test jobs. I think |
PS: Using GH Actions is a lot faster than using Travis. By the time all jobs for commit b9c2c25 had completed in GHActions, neither of the travis builds had yet started. |
@@ -39,7 +39,7 @@ class NonBalancingIntegrationSpec(backend: String) | |||
implicit val mat = SystemMaterializer(system).materializer | |||
implicit val ec = system.dispatcher | |||
|
|||
override implicit val patienceConfig: PatienceConfig = PatienceConfig(5.seconds, Span(10, org.scalatest.time.Millis)) | |||
override implicit val patienceConfig: PatienceConfig = PatienceConfig(15.seconds, Span(10, org.scalatest.time.Millis)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see if that makes the tests a bit less flaky on GHActions
I think the main blocker for this to move on is the flakiness of |
To reduce the chance of not finding the 'good' endpoint among invalid ones Fixes #1327
26c938c
to
1d49881
Compare
(took the liberty of rebasing on top of #1331 to see how that affects this PR) |
Ironic that on this PR introducing GH Actions, the travis tests are red (specifically |
interop-tests/src/test/scala/akka/grpc/scaladsl/NonBalancingIntegrationSpec.scala
Outdated
Show resolved
Hide resolved
// A first successful request. A vanilla probe... | ||
val discoveryHappyPath = new MutableServiceDiscovery(List(server.localAddress)) | ||
val serviceClient = | ||
GreeterServiceClient(GrpcClientSettings.usingServiceDiscovery("greeter", discoveryHappyPath).withTls(false)) | ||
serviceClient.sayHello(HelloRequest(s"Hello")).futureValue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not anymore, no.
6ef141a
to
f3d0e4b
Compare
References #1324 (built on top of #1326 so the PR runs the new workflow)
This is part of the migrations:
This first PR is down-scoped to migrating the build and test jobs (1.1).
Once these compile and test jobs (
1.1
) in GH Actions are stable, I would migrate the release jobs from Travis/Bintray to GHActions/Sonatype in a single PR. That is, I would do1.2.
and2.
at once.