New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change comments in CacheDirective to scaladoc #1514

Closed

matsluni opened this issue Nov 2, 2017 · 1 comment

Milestone

Contributor

matsluni commented Nov 2, 2017

In one comment of PR 1211 @ktoso requested a change from a comment to a actual scaladoc for the link to the rfc document.

Should this be applied to all of the links in this file?

There a more classes where this could be changed, e.g. HttpCookie.scala, what about those?

Member

raboof commented Nov 3, 2017

I think that would be nice!

tom-walford added a commit to tom-walford/akka-http that referenced this issue


          Change comments in CacheDirective to scaladoc akka#1514

bfbd58a

* Updated comments in CacheDirective to be scaladocs
* Updated comments in HttpCookie to be scaladocs
* Updated comments in LinkValue to be scaladocs

jrudolph closed this as completed in

a5061c6

jrudolph added this to the 10.0.11 milestone

jrudolph mentioned this issue

Change comments in CacheDirective to scaladoc #1514 #1521

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment