-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Akka 2.5.10 and use the new version checker utility #1880
Require Akka 2.5.10 and use the new version checker utility #1880
Conversation
Test FAILed. |
Ach, some issue with the |
@raboof Any clue why this happens? The paradox directive does not find |
@johanandren the error is @richardimaoka added searching by fqdn in https://github.com/akka/akka/pull/24563/files#diff-c858760d32fe74f2dcabf0ea7bc4aaecR32 , I guess we'd want to add that and use it here as well (until we move that directive to its own plugin). |
Another solution for often used names like |
Sorry, I was perhaps a bit unclear, in addition to the CI-server fail, I also tried with the fqcn |
Haha, no sorry, now I misread both of your comments. Just ignore me, thanks. |
Something I'd like to add though, why did it stop working now all of a sudden, both of those two classes was surely on the class path before as well? |
Hmm, that's indeed strange.. |
Giving this one up for now, created a separate issue about upgrading Akka version and dealing with the directive. |
We didn't see this problem before because akka-stream didn't depend on akka-protobuf before, it does since akka/akka#24230 |
Test FAILed. |
a591d86
to
77a046a
Compare
Test FAILed. |
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1538
See issue for discussion if it should really be done.