-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail fast on Akka version mismatch #1538
Comments
There's two main case:
Once 10.1 is out the latter one becomes the first one. This has to be implemented by putting a compile build time akka-version value in the
object (this already exists, just add the akka version in there too). And the check being performed on actor system load / start |
Maybe we should even provide something from Akka core to make this easy for any library built with/on top of Akka? |
Hm, sounds fun actually. Since we have a number of satelite projects |
Ping. I think this is important for Akka HTTP 10.1.0 since dependencies are provided and now we have the utility in Akka. |
I'll PR this |
Not as straight forward as it seems. The version require utility was introduced in 2.5.10 which means that if we start using it, we do not in fact support |
We will never support all of 2.5.x all the way to 2.5.0, because sometimes we have to add things (e.g. in akka-stream) that are needed in akka-http. That's why we need to set a minimum supported version. For 10.1.0 I think it's fine to pick the latest and greatest 2.5.10. Later we will probably be conservative and only bump the minimum when really needed (or at least have some lag of a few patch versions). |
This was merged |
What's the PR it was merged in, because my PR was just closed. |
Oh :/ Sneezed my brain out today it seems |
When getting an older Akka version pulled into a project than what is supported by/works with Akka HTTP you get missing method errors etc but would be nice if we instead could check on load of the extension and fail fast with a nice error message saying "You have Akka 2.x.y in your class path but need at least Akka version 2.a.b".
The text was updated successfully, but these errors were encountered: