New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Akka 2.5.10 and use the new version checker utility #1880

Merged
merged 2 commits into from Sep 20, 2018

Conversation

Projects
None yet
4 participants
@johanandren
Copy link
Member

johanandren commented Feb 23, 2018

Fixes #1538

See issue for discussion if it should really be done.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Feb 23, 2018

Test FAILed.

@johanandren

This comment has been minimized.

Copy link
Member

johanandren commented Feb 23, 2018

Ach, some issue with the @unidoc directive. No idea why it hit me here.

@johanandren

This comment has been minimized.

Copy link
Member

johanandren commented Feb 23, 2018

@raboof Any clue why this happens? The paradox directive does not find akka.util.ByteString any more after the 2.5.10 upgrade (see the build fail). I have verified it is not among the class names passed to the directive.

@raboof raboof self-assigned this Feb 26, 2018

@raboof

This comment has been minimized.

Copy link
Member

raboof commented Feb 26, 2018

@johanandren the error is Error writing content for page migration-guide/migration-from-spray.html: 2 matches found for ByteString, but not javadsl/scaladsl: akka.protobuf.ByteString, akka.util.ByteString, which means that it did find akka.util.ByteString, but it now also finds akka.protobuf.ByteString and doesn't know which one to pick.

@richardimaoka added searching by fqdn in https://github.com/akka/akka/pull/24563/files#diff-c858760d32fe74f2dcabf0ea7bc4aaecR32 , I guess we'd want to add that and use it here as well (until we move that directive to its own plugin).

@jrudolph

This comment has been minimized.

Copy link
Member

jrudolph commented Feb 26, 2018

@richardimaoka added searching by fqdn in https://github.com/akka/akka/pull/24563/files#diff-c858760d32fe74f2dcabf0ea7bc4aaecR32 , I guess we'd want to add that and use it here as well (until we move that directive to its own plugin).

Another solution for often used names like ByteString could either be an explicit configured disambiguation option ("ByteString should always mean akka.util.ByteString") or a manual exclusion list where we could put classes from "impl" packages or from "akka.proto".

@johanandren

This comment has been minimized.

Copy link
Member

johanandren commented Feb 26, 2018

Sorry, I was perhaps a bit unclear, in addition to the CI-server fail, I also tried with the fqcn akka.utils.ByteString but that is also not found, and when I look at the classnames passed to the paradox-extension-tag-tingie akka.utils.ByteString is not among them for some reason.

@johanandren

This comment has been minimized.

Copy link
Member

johanandren commented Feb 26, 2018

Haha, no sorry, now I misread both of your comments. Just ignore me, thanks.

@johanandren

This comment has been minimized.

Copy link
Member

johanandren commented Feb 26, 2018

Something I'd like to add though, why did it stop working now all of a sudden, both of those two classes was surely on the class path before as well?

@raboof

This comment has been minimized.

Copy link
Member

raboof commented Feb 26, 2018

Hmm, that's indeed strange..

@johanandren

This comment has been minimized.

Copy link
Member

johanandren commented Feb 27, 2018

Giving this one up for now, created a separate issue about upgrading Akka version and dealing with the directive.

@raboof

This comment has been minimized.

Copy link
Member

raboof commented Feb 28, 2018

We didn't see this problem before because akka-stream didn't depend on akka-protobuf before, it does since akka/akka#24230

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Sep 20, 2018

Test FAILed.

@raboof raboof force-pushed the johanandren:wip-1538-fail-fast-on-version-mismatch-johanandren branch from a591d86 to 77a046a Sep 20, 2018

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Sep 20, 2018

Test FAILed.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

akka-ci commented Sep 20, 2018

Test PASSed.

@raboof

raboof approved these changes Sep 20, 2018

@jrudolph
Copy link
Member

jrudolph left a comment

LGTM

@jrudolph jrudolph merged commit 5ff4319 into akka:master Sep 20, 2018

3 checks passed

Jenkins PR Validation Test PASSed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment