Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaladoc generation fails with 2.12.0-RC1: illegal inheritance from sealed class HttpCredentials #468

Closed
ktoso opened this issue Nov 2, 2016 · 3 comments
Labels
t:docs Issues related to the documentation
Milestone

Comments

@ktoso
Copy link
Member

ktoso commented Nov 2, 2016

Issue by SethTisue
Friday Sep 23, 2016 at 20:16 GMT
Originally opened as akka/akka#21543


running ++2.12.0-RC1 akka-http-core/compile:doc with this additional patch (version number obtained by consulting this):

diff --git a/project/Dependencies.scala b/project/Dependencies.scala
index 70ec683..b42fbeb 100644
--- a/project/Dependencies.scala
+++ b/project/Dependencies.scala
@@ -30,6 +30,7 @@ object Dependencies {
       scalaVersion.value match {
         case "2.12.0-M4" => "0.8.0-RC1"
         case "2.12.0-M5" => "0.8.0-RC3"
+        case x if x.startsWith("2.12.0-RC1") => "0.8.0-RC7"
         case _ => "0.7.0"
       }
     }

results in:

[info] Main Scala API documentation to /Users/tisue/akka/akka-http-core/target/api...
[error] /Users/tisue/akka/akka-http-core/src/main/java/akka/http/javadsl/model/headers/BasicHttpCredentials.java:7: illegal inheritance from sealed class HttpCredentials
[error] public abstract class BasicHttpCredentials extends akka.http.scaladsl.model.headers.HttpCredentials {
[error]                                                                                     ^
[error] /Users/tisue/akka/akka-http-core/src/main/java/akka/http/javadsl/model/headers/OAuth2BearerToken.java:7: illegal inheritance from sealed class HttpCredentials
[error] public abstract class OAuth2BearerToken extends akka.http.scaladsl.model.headers.HttpCredentials {
[error]                                                                                  ^
[info] No documentation generated with unsuccessful compiler run
[error] two errors found
[error] (akka-http-core/compile:doc) Scaladoc generation failed

perhaps this has to do with scala/scala#5246?

discovered by the Scala community build

@ktoso
Copy link
Member Author

ktoso commented Nov 2, 2016

Comment by patriknw
Tuesday Sep 27, 2016 at 06:06 GMT


@jrudolph What do you think about this issue? I tried to remove the sealed and then it works fine. We have many other sealed abstract class in the http-core model, but maybe it's only this HttpCredentials that is extended from java?

@ktoso
Copy link
Member Author

ktoso commented Nov 2, 2016

Comment by patriknw
Tuesday Oct 11, 2016 at 07:09 GMT


ping @jrudolph

@ktoso
Copy link
Member Author

ktoso commented Nov 2, 2016

Comment by patriknw
Monday Oct 31, 2016 at 15:22 GMT


Closing here, it will be handled in akka-http. I commented in #437 (comment)

@ktoso ktoso changed the title [CLOSED] Scaladoc generation fails with 2.12.0-RC1: illegal inheritance from sealed class HttpCredentials Scaladoc generation fails with 2.12.0-RC1: illegal inheritance from sealed class HttpCredentials Nov 2, 2016
ktoso added a commit to ktoso/akka-http that referenced this issue Nov 2, 2016
@ktoso ktoso added this to the FIRST_STABLE milestone Nov 3, 2016
@ktoso ktoso added t:docs Issues related to the documentation 3 - in progress Someone is working on this ticket labels Nov 3, 2016
@ktoso ktoso removed the 3 - in progress Someone is working on this ticket label Nov 3, 2016
@ktoso ktoso closed this as completed Nov 3, 2016
@ktoso ktoso modified the milestones: 10.0.0 "first stable", Final HTTP/2, 10.0.0-RC2 Nov 10, 2016
jedrekn pushed a commit to jedrekn/akka-http that referenced this issue Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:docs Issues related to the documentation
Projects
None yet
Development

No branches or pull requests

1 participant