Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpApp missing simplest startServer overload #873

Closed
ktoso opened this issue Feb 17, 2017 · 4 comments
Closed

HttpApp missing simplest startServer overload #873

ktoso opened this issue Feb 17, 2017 · 4 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding
Milestone
10.0.4

Comments

@ktoso
Copy link
Member

ktoso commented Feb 17, 2017

The:

  def startServer(host: String, port: Int, settings: ServerSettings): Unit = {

is missing the simplest overload:

  def startServer(host: String, port: Int): Unit = ???

we should add it.

cc @jlprat
@ktoso ktoso added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding labels Feb 17, 2017
@ktoso ktoso added this to the 10.0.4 milestone Feb 17, 2017
@ktoso
Copy link
Member Author

ktoso commented Feb 17, 2017

Bumped into this while prepping code for conference demo :-)
I'll see if people like it :-)

@jlprat
Copy link
Member

jlprat commented Feb 17, 2017

You are right, I was having a similar thought some days ago.
I could provide a PR if you like.

Let me know what people say about it :)

@ktoso
Copy link
Member Author

ktoso commented Feb 17, 2017 via email

jlprat added a commit to jlprat/akka-http that referenced this issue Feb 18, 2017
@jlprat
Provide simplest startServer overload akka#873
dc84b28 
Issue: akka#873
Provide start server with only host and port
Update docu
@jlprat jlprat mentioned this issue Feb 18, 2017
Merged
jrudolph added a commit that referenced this issue Feb 21, 2017
@jrudolph
Merge pull request #876 from jlprat/httpApp-simple
1d4def1 
Improve HttpApp usability #873 #875
@jrudolph
Copy link
Member

Fixed by #876.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding
Projects
None yet
Milestone
10.0.4
Development

No branches or pull requests
3 participants
@jrudolph @ktoso @jlprat