-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpApp - should it also mix-in Directives #875
Labels
1 - triaged
Tickets that are safe to pick up for contributing in terms of likeliness of being accepted
t:java
Issues related to the Java DSL
Milestone
Comments
I'm in for it, didn't do it before because mainly all Scala snippets do not extend You know it was a long PR ;) |
BTW, the Java version extends |
Hm yeah we should make them 1:1 matching.
Looking for down sides but so far seems ok to do.
…On Feb 18, 2017 12:44, "Josep Prat" ***@***.***> wrote:
BTW, the Java version extends AllDirectives. So I guess it makes sense to
do the same for the Scala one
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#875 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAHYkzktdm3F--H8NLoSkCEDnAyJIp-Iks5rdtmngaJpZM4MEzCg>
.
|
I can add this to the #876 |
jlprat
added a commit
to jlprat/akka-http
that referenced
this issue
Feb 18, 2017
Update tests and docs
jrudolph
added
1 - triaged
Tickets that are safe to pick up for contributing in terms of likeliness of being accepted
t:java
Issues related to the Java DSL
labels
Feb 20, 2017
Fixed by #876. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1 - triaged
Tickets that are safe to pick up for contributing in terms of likeliness of being accepted
t:java
Issues related to the Java DSL
This I'm actually not sure I'd want but wanted to discuss how you feel about it @jlprat...
To be the "one and single extends you need" we could also make it extend Directives
Nowadays to be ready to work with it I'd need:
WDYT?
The text was updated successfully, but these errors were encountered: