Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpApp - should it also mix-in Directives #875

Closed
ktoso opened this issue Feb 17, 2017 · 5 comments
Closed

HttpApp - should it also mix-in Directives #875

ktoso opened this issue Feb 17, 2017 · 5 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:java Issues related to the Java DSL
Milestone

Comments

@ktoso
Copy link
Member

ktoso commented Feb 17, 2017

This I'm actually not sure I'd want but wanted to discuss how you feel about it @jlprat...

To be the "one and single extends you need" we could also make it extend Directives

Nowadays to be ready to work with it I'd need:

object FeedFromHttpPostApp extends App with HttpApp with Directives

WDYT?

@jlprat
Copy link
Member

jlprat commented Feb 18, 2017

I'm in for it, didn't do it before because mainly all Scala snippets do not extend Directives, but import them. I wanted to avoid the feeling that "HttpApp is deciding too many things for me"

You know it was a long PR ;)

@jlprat
Copy link
Member

jlprat commented Feb 18, 2017

BTW, the Java version extends AllDirectives. So I guess it makes sense to do the same for the Scala one

@ktoso
Copy link
Member Author

ktoso commented Feb 18, 2017 via email

@jlprat
Copy link
Member

jlprat commented Feb 18, 2017

I can add this to the #876

jlprat added a commit to jlprat/akka-http that referenced this issue Feb 18, 2017
@jrudolph jrudolph added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:java Issues related to the Java DSL labels Feb 20, 2017
@jrudolph jrudolph assigned jrudolph and unassigned jrudolph Feb 20, 2017
jrudolph added a commit that referenced this issue Feb 21, 2017
@jrudolph
Copy link
Member

Fixed by #876.

@jrudolph jrudolph added this to the 10.0.4 milestone Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:java Issues related to the Java DSL
Projects
None yet
Development

No branches or pull requests

3 participants