Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic support for trailing-slash agnostic routes #880

Closed
jrudolph opened this issue Feb 20, 2017 · 2 comments
Closed

Automatic support for trailing-slash agnostic routes #880

jrudolph opened this issue Feb 20, 2017 · 2 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Identifies issues that the core team will likely not have time to work on t:routing Issues related to the routing DSL
Milestone
10.0.7

Comments

@jrudolph
Copy link
Member

There has been ongoing debate whether in which cases to use trailing slashes in URIs. We already provide redirectToTrailingSlashIfMissing and redirectToNoTrailingSlashIfPresent to support both kind of styles. We might think about also supporting a directive that retries a request stripping off (or adding) a trailing slash if the first run failed with an empty rejection (= 404).

/cc @lihaoyi
@jrudolph jrudolph added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Identifies issues that the core team will likely not have time to work on t:routing Issues related to the routing DSL labels Feb 20, 2017
@jlprat
Copy link
Member

jlprat commented Apr 3, 2017

I will try to come up with a directive for this case.

@jlprat jlprat mentioned this issue Apr 12, 2017
Merged
jlprat added a commit to jlprat/akka-http that referenced this issue Apr 27, 2017
@jlprat
Retry inner route only if empty rejection happened
edbc7d5 
Issue: akka#880
Add docs
Add Java API
Add tests
jlprat added a commit to jlprat/akka-http that referenced this issue May 6, 2017
@jlprat
Add directive IgnoreTrailingSlash akka#880
8580689 
Issue: akka#880
Provide directive that retries inner route flipping trailing slash if rejected with empy rejections
Add docs
Add Java API
Add tests
jlprat added a commit to jlprat/akka-http that referenced this issue May 6, 2017
@jlprat
Add directive IgnoreTrailingSlash akka#880
ed877f7 
Issue: akka#880
Provide directive that retries inner route flipping trailing slash if rejected with empy rejections
Add docs
Add Java API
Add tests
jrudolph pushed a commit that referenced this issue May 16, 2017
@jlprat @jrudolph
+htp #880 Add PathDirectives.ignoreTrailingSlash (#1027)
a99036d
@jrudolph jrudolph added this to the 10.0.7 milestone May 16, 2017
@jrudolph
Copy link
Member Author

Fixed with #1027.

@ktoso ktoso removed the 3 - in progress Someone is working on this ticket label May 25, 2017
tomrf1 pushed a commit to tomrf1/akka-http that referenced this issue Aug 13, 2017
@jlprat @tomrf1
+htp akka#880 Add PathDirectives.ignoreTrailingSlash (akka#1027)
74c9ee9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Identifies issues that the core team will likely not have time to work on t:routing Issues related to the routing DSL
Projects
None yet
Milestone
10.0.7
Development

No branches or pull requests
3 participants
@jrudolph @ktoso @jlprat