Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpApp.route perhaps should be called routes? #953

Closed
ktoso opened this issue Mar 9, 2017 · 5 comments
Closed

HttpApp.route perhaps should be called routes? #953

ktoso opened this issue Mar 9, 2017 · 5 comments
Labels
discuss Tickets that need some discussion before proceeding
Milestone
10.0.7

Comments

@ktoso
Copy link
Member

ktoso commented Mar 9, 2017

I somehow feel routes would be more natural.

As one would say "and here we define the routes".

WDYT?
@ktoso
Copy link
Member Author

ktoso commented Mar 9, 2017

https://github.com/akka/akka-http/blob/master/akka-http/src/main/scala/akka/http/scaladsl/server/HttpApp.scala#L149

@ktoso ktoso added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted discuss Tickets that need some discussion before proceeding labels Mar 9, 2017
@ktoso ktoso added this to the 10.0.x milestone Mar 9, 2017
@jlprat
Copy link
Member

jlprat commented Mar 10, 2017

I have no strong opinion, I agree routes is more natural and route maybe is closer to the type. But I tend to agree with you.

We could maybe just deprecate the route method, instead of removing it, just to keep some source compatibility.

@viktorklang
Copy link
Member

viktorklang commented Mar 10, 2017 via email

@jlprat
Copy link
Member

jlprat commented Apr 21, 2017

Any further opinions? just rename it to routes?

@ktoso
Copy link
Member Author

ktoso commented Apr 24, 2017

Yes, just add a method routes and make the route deprecated I guess

@ktoso ktoso closed this as completed Apr 24, 2017
@ktoso ktoso reopened this Apr 24, 2017
jlprat added a commit to jlprat/akka-http that referenced this issue Apr 28, 2017
@jlprat
Provide routes method in HttpApp akka#953
afc2c28 
Issue: akka#953
Provide routes method in HttpApp
Deprecate route mothod in HttpApp
Use the new method in tests and docs
Update docs
HttpApp still uses the route method internally to ease the update
@jlprat jlprat mentioned this issue Apr 28, 2017
Merged
jlprat added a commit to jlprat/akka-http that referenced this issue May 6, 2017
@jlprat
Provide routes method in HttpApp akka#953
0b090a4 
Issue: akka#953
Provide routes method in HttpApp
Deprecate route mothod in HttpApp
Use the new method in tests and docs
Update docs
HttpApp still uses the route method internally to ease the update
@jrudolph jrudolph modified the milestones: 10.0.x, 10.0.7 May 11, 2017
@jlprat jlprat removed the 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted label May 11, 2017
@ktoso ktoso removed the 3 - in progress Someone is working on this ticket label May 25, 2017
tomrf1 pushed a commit to tomrf1/akka-http that referenced this issue Aug 13, 2017
@jlprat @tomrf1
!htp akka#953 Rename HttpApp.route to routes (akka#1070)
b59d5de 
Fixes akka#953.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss Tickets that need some discussion before proceeding
Projects
None yet
Milestone
10.0.7
Development

No branches or pull requests
4 participants
@jrudolph @viktorklang @ktoso @jlprat