New module: Akka-HTTP-Caching #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename to Lfu Make remove return Unit Move caffeine dependency to Dependencies.scala Fix CachingDirectives package name Increase delay in cache test @ApiMayChange annotations Remove test that sometimes fails due to race condition Exclude akka-http-caching from MiMa previous artifacts Remove the need for a loader on LfuCache creation Simplify CachingDirectives - remove CacheSpecMagnet MiMa ignoredModules Refactor LfuCache - replace subclasses with store param Docs and example code for caching directives Move LfuCache params to LfuCacheSettings to support binary compatibility Replace Keyed and ValueMagnet classes with overloaded apply and get methods Remove default value for keyer function Remove build.sbt Update docs Make cache key type generic Fix Cache.remove comment WIP towards JavaDSL for akka-http-caching Use JavaMapping formatting copyright, docs, annotations Make CacheJavaMapping internal Java API markers getStrict -> getOrCreateStrict Remove simpleKeyer Use LfuCacheSettings in routeCache Example keyer for docs Fix for sbt 1.0 Make Java DSL implement proper CachingSettings companion =cache make settings reference.conf and mark things as internal
=doc Add server-side overview page (#1371) Revert formatting changes back to how Scalariform formats Mark more settings constructors private Use self reference to implement with... methods Override productPrefix in the setting implementations Fix implementation of withLfuCacheSettings Implement withLfuCacheSettings in the Java DSL and provide a Scala-specific implementation as well. Fix compilation error in the caching directive example Fix places where the Java DSL leaks into the Scala DSL For example apply methods should always take the Scala DSL instance where as create methods should take the Java DSL instances. Caching docs (#6) * Fix use of fragments and IDs in directives * Add Java caching directives examples * Document Java caching directives * Document the caching design and implementation Port spray-caching documentation and update to the new caching API. * Document the akka-http-caching reference config * Fix reference to Java DSL cache * Fix another Cache reference * Reword docs related to the LFU cache
akka-ci
added
validating
|
Test PASSed. |
|
L G T M !
|
|
Thanks @tomrf1 @ben-manes @jonas @jrudolph @yannick-cw et al for all the help, code and reviews. Very excited we finally got it in; I'm sorry it took us so long, but the outcome is very excellent so far :) There's some small follow up ticktes already:
t:caching
Resolves #213 |
|
And of course after writing "watch out with merging" I merge it using the wrong button... I'll fix it, so everyone gets attribution. |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed version of #1503