-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: also go through state machine for resetStream
#3584
Merged
jrudolph
merged 2 commits into
akka:master
from
jrudolph:handle-resetStream-through-state-machine
Nov 2, 2020
Merged
http2: also go through state machine for resetStream
#3584
jrudolph
merged 2 commits into
akka:master
from
jrudolph:handle-resetStream-through-state-machine
Nov 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
approved these changes
Oct 29, 2020
akka-http-core/src/main/scala/akka/http/impl/engine/http2/Http2StreamHandling.scala
Show resolved
Hide resolved
akka-ci
added
validating
PR that is currently being validated by Jenkins
needs-attention
Indicates a PR validation failure (set by CI infrastructure)
and removed
validating
PR that is currently being validated by Jenkins
labels
Oct 29, 2020
Test FAILed. |
PLS BUILD |
akka-ci
added
validating
PR that is currently being validated by Jenkins
tested
PR that was successfully built and tested by Jenkins
and removed
needs-attention
Indicates a PR validation failure (set by CI infrastructure)
validating
PR that is currently being validated by Jenkins
labels
Oct 29, 2020
Test PASSed. |
ignasi35
reviewed
Oct 29, 2020
akka-http-core/src/main/scala/akka/http/impl/engine/http2/Http2StreamHandling.scala
Show resolved
Hide resolved
ignasi35
reviewed
Oct 29, 2020
akka-http-core/src/main/scala/akka/http/impl/engine/http2/Http2StreamHandling.scala
Show resolved
Hide resolved
ignasi35
approved these changes
Oct 29, 2020
akka-ci
added
validating
PR that is currently being validated by Jenkins
tested
PR that was successfully built and tested by Jenkins
and removed
tested
PR that was successfully built and tested by Jenkins
validating
PR that is currently being validated by Jenkins
labels
Oct 29, 2020
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid uncontrolled reentry into state machine. Will conflict with #3581.