Akka HTTP BOM #3665
Merged
Akka HTTP BOM #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka-ci
added
validating
|
Test PASSed. |
raboof
reviewed
Nov 25, 2020
build.sbt
Outdated
| @@ -46,6 +46,25 @@ inThisBuild(Def.settings( | |||
| scalafixScalaBinaryVersion := scalaBinaryVersion.value, | |||
| )) | |||
|
|
|||
| // When this is updated the set of modules in ActorSystem.allModules should also be updated | |||
There was a problem hiding this comment.
Suggested change
| // When this is updated the set of modules in ActorSystem.allModules should also be updated |
There was a problem hiding this comment.
I accepted your suggestion and then realized the comment is required (but was wrong). It should read In Http.allModules.
akka-ci
added
validating
|
Test PASSed. |
Co-authored-by: Arnout Engelen <github@bzzt.net>
akka-ci
added
validating
|
Test PASSed. |
akka-ci
added
validating
|
Test PASSed. |
ignasi35
commented
Nov 26, 2020
|
We need to settle the discussion in akka/akka#29839 (comment) first. |
akka-ci
added
validating
|
Test PASSed. |
ignasi35
commented
Nov 30, 2020
project/plugins.sbt
Outdated
| @@ -17,6 +17,7 @@ addSbtPlugin("net.virtual-void" % "sbt-dependency-graph" % "0.10.0-RC1") // for | |||
| addSbtPlugin("io.spray" % "sbt-boilerplate" % "0.6.1") | |||
| addSbtPlugin("org.foundweekends" % "sbt-bintray" % "0.6.1") | |||
| addSbtPlugin("com.lightbend.sbt" % "sbt-publish-rsync" % "0.2") | |||
| addSbtPlugin("com.lightbend.sbt" % "sbt-bill-of-materials" % "1.0.0") | |||
akka-ci
added
validating
|
Test PASSed. |
raboof
approved these changes
Dec 2, 2020
| @@ -1,11 +1,11 @@ | |||
| import akka._ | |||
| import akka.ValidatePullRequest._ | |||
| import AkkaDependency._ | |||
| import Dependencies.{ h2specName, h2specExe } | |||
| import Dependencies.{h2specExe, h2specName} | |||
There was a problem hiding this comment.
surprised this didn't trigger scalariform - I guess it doesn't check the build.sbt?
| @@ -23,7 +23,7 @@ inThisBuild(Def.settings( | |||
| scmInfo := Some( | |||
| ScmInfo(url("https://github.com/akka/akka-http"), "git@github.com:akka/akka-http.git")), | |||
| developers := List( | |||
| Developer("contributors", "Contributors", "akka-user@googlegroups.com", | |||
| Developer("contributors", "Contributors", "info@lightbend.com", | |||
There was a problem hiding this comment.
😆 I'm not sure that would reach us - but akka-user is obviously wrong as well.
There was a problem hiding this comment.
akka.official@gmail.com would reach us though
johanandren
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs playframework/playframework#10549 and akka/akka#29839