Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: remove Http2FrameRendering stage #3838

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

jrudolph
Copy link
Member

The whole reason of the stage was to split DataFrames into chunks fitting
the current SETTINGS_MAX_FRAME_SIZE but that invariant has now for some
time been enforced by the multiplexer directly.

The whole reason of the stage was to split DataFrames into chunks fitting
the current SETTINGS_MAX_FRAME_SIZE but that invariant has now for some
time been enforced by the multiplexer directly.
@jrudolph jrudolph added this to the 10.2.5 milestone Jun 15, 2021
@akka-ci akka-ci added the validating PR that is currently being validated by Jenkins label Jun 15, 2021
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice

@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Jun 15, 2021
@akka-ci
Copy link

akka-ci commented Jun 15, 2021

Test PASSed.

@jrudolph jrudolph merged commit ab3fbee into akka:master Jun 15, 2021
@jrudolph jrudolph deleted the simplify-frame-rendering branch June 15, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants