-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration #440
Migration #440
Conversation
…gement into pluggable-health-check
|
||
Unless used for something other than service discovery / bootstrap the following can be removed from your application.conf | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't look as application.conf as mentioned above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh, deployment.yml
|
||
If `pod-namespace` is set remove from your configuration as it will be automatically picked up from the `/var/run/secrets/kubernetes.io/serviceaccount/namespace` file | ||
that is mounted to each Kubernetes container. The namespace can be overridden with `pod-namespace` if this isn't the desired behavior. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More things:
- Requires HTTP 10.1.7 or later
- Requires Akka 2.5.19 or later
- AkkaManagement moved to package
akka.management.scaladsl.AkkaManagement
- if implementing custom ManagementRouteProvider the package changed to
akka.management.scaladsl.ManagementRouteProvider
AkkaManagement.start
andAkkaManagement.routes
may throwIllegalArgumentException
instead of returningTry
- auth and https has changed by using overloaded methods of
AkkaManagement.start
andAkkaManagement.routes
, see akka-management.md#enabling-basic-authentication - changed configuration path for configuration of
ready-states
- config
akka.management.cluster.bootstrap.form-new-cluster
renamed toakka.management.cluster.bootstrap.new-cluster-enabled
docs/src/main/paradox/migration.md
Outdated
|
||
### Configuration changes | ||
|
||
* `akka.mananagement.cluster.http.healthcheck.ready-states` moved to `akka.mananagement.cluster.healthcheck.ready-states` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
health-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after health-check
Branch based on #438 otherwise the index.md would have conflicted so will merge that one first. Just look at
migration.md
or this commit f10b11dRefs #439