Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration #440

Merged
merged 32 commits into from
Jan 15, 2019
Merged

Migration #440

merged 32 commits into from
Jan 15, 2019

Conversation

chbatey
Copy link
Member

@chbatey chbatey commented Jan 14, 2019

Branch based on #438 otherwise the index.md would have conflicted so will merge that one first. Just look at migration.md or this commit f10b11d

Refs #439


Unless used for something other than service discovery / bootstrap the following can be removed from your application.conf

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look as application.conf as mentioned above

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, deployment.yml


If `pod-namespace` is set remove from your configuration as it will be automatically picked up from the `/var/run/secrets/kubernetes.io/serviceaccount/namespace` file
that is mounted to each Kubernetes container. The namespace can be overridden with `pod-namespace` if this isn't the desired behavior.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More things:

  • Requires HTTP 10.1.7 or later
  • Requires Akka 2.5.19 or later
  • AkkaManagement moved to package akka.management.scaladsl.AkkaManagement
  • if implementing custom ManagementRouteProvider the package changed to akka.management.scaladsl.ManagementRouteProvider
  • AkkaManagement.start and AkkaManagement.routes may throw IllegalArgumentException instead of returning Try
  • auth and https has changed by using overloaded methods of AkkaManagement.start and AkkaManagement.routes, see akka-management.md#enabling-basic-authentication
  • changed configuration path for configuration of ready-states
  • config akka.management.cluster.bootstrap.form-new-cluster renamed to akka.management.cluster.bootstrap.new-cluster-enabled


### Configuration changes

* `akka.mananagement.cluster.http.healthcheck.ready-states` moved to `akka.mananagement.cluster.healthcheck.ready-states`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

health-check

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after health-check

@chbatey chbatey added this to the 1.0.0-RC2 milestone Jan 15, 2019
@chbatey chbatey merged commit af4a816 into akka:master Jan 15, 2019
@chbatey chbatey deleted the migration branch January 15, 2019 08:11
@chbatey chbatey modified the milestones: 1.0.0-RC2, 1.0.0-RC1 Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants