Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite secrets to travis.com #843

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Rewrite secrets to travis.com #843

merged 1 commit into from
Nov 4, 2020

Conversation

ignasi35
Copy link
Member

@ignasi35 ignasi35 commented Nov 3, 2020

References akka/akka-meta#143

@ignasi35
Copy link
Member Author

ignasi35 commented Nov 3, 2020

We may want to backport this to stable branches (but I'd rather hold until we need to do a relese from the stable branch).

@ignasi35 ignasi35 requested a review from chbatey November 3, 2020 17:01
@chbatey
Copy link
Member

chbatey commented Nov 4, 2020

I am missing some context, how do we switch over? I'll assume you know what you are doing :)

@ignasi35
Copy link
Member Author

ignasi35 commented Nov 4, 2020

I am missing some context, how do we switch over? I'll assume you know what you are doing :)

Using travis-ci.com tools the migration is handled by travis infrastructure. The build for this PR was already run on travis-ci.com (https://travis-ci.com/github/akka/akka-persistence-cassandra/builds/197923907).

The missing bit on the migration (which can't be managed by travis infrastructure) is we need to re-encrypt secrets (which this PR does).

Here's an equivalent PR in other repos: akka/akka-persistence-dynamodb#97

We'll know if I encrypted the correct secrets when we run a publish or a whitesource check that uses them :-)

@ignasi35 ignasi35 merged commit 6d08ef9 into akka:master Nov 4, 2020
@ignasi35 ignasi35 deleted the migrate-to-travis-com branch November 4, 2020 10:47
@ignasi35
Copy link
Member Author

ignasi35 commented Nov 4, 2020

There's, at least one error in this PR: https://travis-ci.com/github/akka/akka-persistence-cassandra/builds/198217951

@ignasi35 ignasi35 mentioned this pull request Nov 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbatey chbatey chbatey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ignasi35 @chbatey