Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid using boolean types under Oracle's data type limitations #673 #764

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

Roiocam
Copy link
Contributor

@Roiocam Roiocam commented Sep 6, 2023

References #673

This PR has been fix something like EventsByTagTest, but i got the ERROR on JournalSequenceActorTest.

I think it was my environment complaining database too slow, waiting for investigation.

@Roiocam Roiocam marked this pull request as draft September 6, 2023 10:22
@Roiocam
Copy link
Contributor Author

Roiocam commented Sep 25, 2023

@patriknw These CI checks have passed. Does this mean that this PR has successfully solved #673?

@Roiocam Roiocam marked this pull request as ready for review September 25, 2023 09:57
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing then I think this looks good to merge

Co-authored-by: Johan Andrén <johan@markatta.com>
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@johanandren johanandren merged commit 749efc1 into akka:master Oct 4, 2023
15 checks passed
@johanandren johanandren added this to the 5.3.0-M1 milestone Oct 4, 2023
@Roiocam Roiocam deleted the roiocam-oracle-legacy-it-fix branch October 4, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants