Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failure: Some eventsByTag tests fail with Oracle and legacy.ByteArrayReadJournalDao #673

Open
patriknw opened this issue Sep 5, 2022 · 1 comment
Open

failure: Some eventsByTag tests fail with Oracle and legacy.ByteArrayReadJournalDao #673

patriknw opened this issue Sep 5, 2022 · 1 comment

Comments

@patriknw
Copy link
Member

patriknw commented Sep 5, 2022

Started when logical deletion was removed in #569, but that probably didn't work with logicalDelete=false before that either. It showed up with that change because the default for logical delete was changed.
@patriknw patriknw mentioned this issue Sep 5, 2022
Merged
Roiocam added a commit to Roiocam/akka-persistence-jdbc that referenced this issue Sep 5, 2023
@Roiocam
fix: Avoid using boolean types under Oracle's data type limitations a…
2e3446f 
…kka#673
@Roiocam Roiocam mentioned this issue Sep 6, 2023
Merged
@Roiocam
Copy link
Contributor

Roiocam commented Sep 6, 2023

I believe the reason for this issue is because Oracle does not support the boolean data type. Therefore, after PR #569, the functionality stopped working.

It's frustrating because this problem has recurred in PR #731 and has caused me some difficulty.

截屏2023-09-05 13 38 39

Roiocam added a commit to Roiocam/akka-persistence-jdbc that referenced this issue Sep 28, 2023
@Roiocam
fix: compatible legacy tag read akka#673
f66aeb1
johanandren pushed a commit that referenced this issue Oct 4, 2023
@Roiocam
fix: Avoid using boolean types under Oracle's data type limitations #673
749efc1 
 (#764)
Roiocam added a commit to Roiocam/akka-persistence-jdbc that referenced this issue Oct 8, 2023
@Roiocam
fix: compatible legacy tag read akka#673
71536ce
Roiocam added a commit to Roiocam/akka-persistence-jdbc that referenced this issue Oct 25, 2023
@Roiocam
fix: compatible legacy tag read akka#673
1b5d7e6
octonato pushed a commit that referenced this issue Oct 27, 2023
@Roiocam
Replace event_tag FK to get rid of insert and return #710 (#731)
d4d942e 
* Replace event_tag FK to get rid of insert and return #710

* support rolling updates #710

* remove CRLF #710

* optimized migrator #710

* fixes oracle test #710

* unitTest,SQL for migration #710

* fix MigratorSpec #710

* chore: typo fix #710

* fix: IntegrationTest and clean code #710

* fix: compatible legacy tag read #673

* chore: mi-ma filter for PR

* fix: optimized migrate step

* fix: dialect for column fill

* fix: update migration sql

* fix: mysql dialect

* fix: dialect syntax

* fix: dialect syntax

* fix: avoid use system table of mysql

* fix: batch insert caused flaky test

* fix: insert less event of large batch

* fix: script fix and strongly express two-step update
Bugsource pushed a commit to Bugsource/akka-persistence-jdbc that referenced this issue Jan 8, 2024
@Roiocam
Replace event_tag FK to get rid of insert and return akka#710 (akka#731)
4c5eab8 
* Replace event_tag FK to get rid of insert and return akka#710

* support rolling updates akka#710

* remove CRLF akka#710

* optimized migrator akka#710

* fixes oracle test akka#710

* unitTest,SQL for migration akka#710

* fix MigratorSpec akka#710

* chore: typo fix akka#710

* fix: IntegrationTest and clean code akka#710

* fix: compatible legacy tag read akka#673

* chore: mi-ma filter for PR

* fix: optimized migrate step

* fix: dialect for column fill

* fix: update migration sql

* fix: mysql dialect

* fix: dialect syntax

* fix: dialect syntax

* fix: avoid use system table of mysql

* fix: batch insert caused flaky test

* fix: insert less event of large batch

* fix: script fix and strongly express two-step update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patriknw @Roiocam