Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

akka-http: documentation broken link #20409

Closed
atemerev opened this issue Apr 28, 2016 · 3 comments
Closed

akka-http: documentation broken link #20409

atemerev opened this issue Apr 28, 2016 · 3 comments
Labels
help wanted Issues that the core team will likely not have time to work on t:docs
Milestone
2.4.5

Comments

@atemerev
Copy link
Contributor

Where: http://doc.akka.io/docs/akka/2.4.4/scala/http/routing-dsl/websocket-support.html ("Example" section)

Broken link: http://github.com/akka/akka/tree/v2.4.4/akka-docs-dev/rst/scala/code/docs/http/scaladsl/server/WebSocketExampleSpec.scala

Should be: https://github.com/akka/akka/blob/v2.4.4/akka-docs/rst/scala/code/docs/http/scaladsl/server/WebSocketExampleSpec.scala
@ktoso
Copy link
Member

ktoso commented Apr 28, 2016

Thanks a lot for noticing! Would you like to submit a PR fixing this typo?

@ktoso ktoso added t:docs 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted labels Apr 28, 2016
@ktoso ktoso added this to the 2.4.5 milestone Apr 28, 2016
@ktoso ktoso added the help wanted Issues that the core team will likely not have time to work on label Apr 28, 2016
@atemerev
Copy link
Contributor Author

Sure! #20410

@ktoso ktoso mentioned this issue Apr 28, 2016
Merged
@ktoso ktoso closed this as completed Apr 28, 2016
ktoso pushed a commit that referenced this issue Apr 28, 2016
@atemerev @ktoso
doc #20409 Broken link corrected in Akka HTTP WS server docs (#20410)
f6dbdce 
* Akka-HTTP Websocket server doc (broken link corrected)
@ktoso ktoso removed the 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted label Apr 28, 2016
@ktoso
Copy link
Member

ktoso commented Apr 28, 2016

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues that the core team will likely not have time to work on t:docs
Projects
None yet
Milestone
2.4.5
Development

No branches or pull requests
2 participants
@ktoso @atemerev