Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't (gzip,...) encode known-to-be-empty entities #21393

Closed
jrudolph opened this issue Sep 7, 2016 · 3 comments
Closed

Don't (gzip,...) encode known-to-be-empty entities #21393

jrudolph opened this issue Sep 7, 2016 · 3 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Issues that the core team will likely not have time to work on small t:http:marshalling t:http

Comments

@jrudolph
Copy link
Member

jrudolph commented Sep 7, 2016

Even if the content-type would allow it by having compressible=true set.

Follow up from #20793.
@jrudolph jrudolph added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Issues that the core team will likely not have time to work on t:http small t:http:marshalling labels Sep 7, 2016
@jrudolph jrudolph added this to the 2.4.x milestone Sep 7, 2016
@jrudolph jrudolph changed the title Don't encode known-to-be-empty entities Don't (gzip,...) encode known-to-be-empty entities Sep 7, 2016
@jrudolph jrudolph mentioned this issue Sep 7, 2016
Closed
@gosubpl
Copy link
Contributor

gosubpl commented Sep 7, 2016

Looking into this. The plan is to modify relevant checks or definition of isCompressible in Encoder.scala, as per previous discussion in #20793

@gosubpl
Copy link
Contributor

gosubpl commented Sep 7, 2016

Ah, I have missed fromStatusCodeAndHeadersAndValue marshaller in the fix for #20793 . Will fix in this PR.

gosubpl added a commit to gosubpl/akka that referenced this issue Sep 7, 2016
@gosubpl
=htc don't encode known to be empty entities (akka#21393)
21e5aec
@gosubpl gosubpl mentioned this issue Sep 7, 2016
Merged
gosubpl added a commit to gosubpl/akka that referenced this issue Sep 7, 2016
@gosubpl
=htc added missing headers in the improved marshaller (akka#21393)
0d562ab
@akka-ci akka-ci mentioned this issue Sep 8, 2016
Closed
@ktoso
Copy link
Member

ktoso commented Sep 8, 2016

Ticket moved to github.com/akka/akka-http
Rationale for the move discussed here: akka/akka-meta#27

If you are interested in contributing or tracking this issue, please comment in akka-http instead from now on :-)

@ktoso ktoso closed this as completed Sep 8, 2016
ktoso pushed a commit that referenced this issue Sep 13, 2016
@gosubpl @ktoso
=htc don't encode known to be empty entities (#21393) (#21396)
9b73fef 
* =htc don't encode known to be empty entities (#21393)

* =htc added missing headers in the improved marshaller (#21393)
@patriknw patriknw modified the milestone: 2.4.x Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted help wanted Issues that the core team will likely not have time to work on small t:http:marshalling t:http
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jrudolph @ktoso @patriknw @gosubpl